Conversation
DirkDoes
added this pull request to stack #503
September 28, 2026 21:03
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Let the localization service own language-change events and have the global facade forward them. XAML translation markup now returns an observable binding that updates on the UI thread.
Refresh persistent layout text and active settings labels/dropdowns in place. Changing the language no longer recreates the main window or current page.
Based on #500. Merge after the lower layers; no validation-PR dependency.
How to Test:
dotnet test WheelWizard.sln582 tests passed (562 unit, 20 headless UI). Checks retain the same window/page/control instances, verify background-thread binding updates and disposal, and verify event forwarding when services change. Manually switch languages in settings and confirm focus/navigation state is preserved.
What Has Been Changed:
See the focused implementation above. The existing settings JSON contract and imported translation sheets are preserved.
Related Issue Link:
No linked issue. Part of native GitHub stack #503.
Checklist before merging