[refactor/#421] Recommendation application 경계 정리#454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
Recommendation application 코드가 다른 컨텍스트의 repository를 직접 참조하던 경계를 lookup/application seam으로 정리했습니다.
RecommendationCommandService,RecommendationQueryService,RecommendationScheduler의UserRepository직접 의존을UserLookupService로 전환BookmarkLookupService의 bulk ID 계약으로 전환LlmRecommendationService의ReadPostRepository,PostRepository,PersonalizationProfileDocumentRepository직접 의존 제거ReadPostLookupService의 post ID 집합으로 제공PostLookupService로 캡슐화연결된 issue
close #421
✅ 체크리스트
🧪 테스트 결과
./gradlew test— 497개 테스트 통과UserLookupServiceTest,RecommendationCommandServiceTest,RecommendationQueryServiceTest— 9개 테스트 통과PersonalizationProfileLookupItemTest,PersonalizationProfileLookupServiceTest,LlmRecommendationServiceTest— 13개 테스트 통과RecommendationIntegrationTest— 4개 테스트 통과git diff --check