Repository navigation
ci: stop formatters fighting generated data files #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Prettier ignore | ||
| # | ||
| # Script-generated JSON data files. These are written by | ||
| # `model-benchmarks/scripts/*.py` via `json.dump(..., indent=2)`, which expands | ||
| # every array to one element per line. Prettier collapses short arrays onto a | ||
| # single line, so the two formatters disagree permanently: every pipeline run | ||
| # rewrites the file, Prettier reformats it, and the pre-commit hook fails. | ||
| # | ||
| # That conflict left `main` red on six consecutive pre-commit runs (2026-07-25 | ||
| # through 2026-07-28) and the failures were misattributed to whichever PR | ||
| # happened to be open, which is how PR #23 sat blocked for five review passes on | ||
| # a check that had nothing to do with it. | ||
| # | ||
| # These files are machine-written and machine-read; their formatting is decided | ||
| # by the generator, not by a human editing them. Prettier has no useful opinion | ||
| # here. | ||
| model-benchmarks/data/model-data.json | ||
| model-benchmarks/data/eqbench-upstream-keys.json | ||
| model-benchmarks/data/eqbench-raw.json | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
eqbench-upstream-keys.jsonbecomes malformed—for example after manual conflict resolution or an interrupted write—this exclusion removes the only configured hook that parses the file as JSON. The benchmark test hook only selects changes undermodel-benchmarks/scriptsormodel-benchmarks/tests, and its snapshot tests use temporary files rather than this checked-in snapshot, so a data-only commit can pass pre-commit and then make the weekly watcher fail inload_snapshot(). Add a non-formatting JSON syntax check while excluding these files from Prettier.Useful? React with 👍 / 👎.