Repository navigation
Conversation
u7-u7
marked this pull request as ready for review
November 3, 2026 13:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wait-for-element --selector '#mask' --state hidden(anddetached) can report success while a visible replacement still matches#mask. A dynamic page may replace the node afterDOM.describeNodebut beforeDOM.resolveNode, or after the remote object is resolved but before its visibility probe. Both cases currently turn the retired physical node into an observation that the selector is absent. The wait returns immediately, allowing the caller to advance while the replacement loading mask remains visible.The earlier lookup-stage retry already handles removal during
DOM.describeNode; these later two windows were not covered.Change
Treat a removed selector target as an incomplete probe and re-query it using the existing bounded polling loop. A fresh unmatched query still satisfies
hidden/detached. Preserve physical-node semantics forrefwaits, their invalidation errors, cancellation, deadlines, object-group cleanup and last completed evidence. No protocol, permission, dependency, timing-default or action-replay changes.Validation
Base:
b8f2d4f0fa35c8c7c866229e1cf3b3329ae39de5.handleWaitForElemententry point and session/ref handling with controlled CDP replies and fake timers.satisfied: trueat 0 ms instead of continuing to the 100 ms deadline.vitest run --maxWorkers=1, 184.30 seconds).tsc --noEmit, production extensionwxt build, Biome on both changed files andgit diff --check: passed.Commands use the repository-locked dependencies. Initial
pnpm install --frozen-lockfileneeded a writable store/cache; its rerun installed dependencies and successfully ranwxt prepare, but exited with the unapproved optional@parcel/watcherbuild-script notice. No additional build scripts were approved and no workspace/lockfile changes are included.No native Chrome fixture, installed extension/daemon end-to-end flow, Rust suite or upstream CI is claimed from these local results.
AI assistance
Investigated, implemented, tested and independently reviewed with OpenAI Codex agents. Draft for maintainer review; no human-review attestation is claimed.