Repository navigation
fix(knowledge): preserve remote embedding order - #1454
Merged
Bosheng0422 merged 3 commits intoNov 2, 2026
Merged
Conversation
AbelTomato
marked this pull request as ready for review
October 1, 2026 16:30
This was referenced Oct 4, 2026
Contributor
Author
|
@jubaoliang-tencent 请批准运行工作流 |
Collaborator
|
Maintainer triage note Preserving remote embedding order (#1453) looks correct. Fork CI approval has been granted. Please rebase onto latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect vector-to-text alignment when a remote embedding provider
returns results in a different order from the input texts.
The implementation now restores the input order using each response item's
indexand rejects malformed responses with invalid, duplicate, or missingindexes.
Fixed #1453
Target branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
make allpasses locallyChecklist
CHANGELOG.md(if user-facing)