Skip to content

feat(acp): multi-expert inbound ACP with lean cold start - #2468

Open
huangcheng wants to merge 5 commits into
TencentCloud:developfrom
huangcheng:feature/acp-inbound-multi-expert
Open

huangcheng wants to merge 5 commits into
TencentCloud:developfrom
huangcheng:feature/acp-inbound-multi-expert

Conversation

@huangcheng

@huangcheng huangcheng commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • octop acp advertises all local experts as ACP configOptions (id=expert); --agent is optional (CLI default / first agent)
  • Boots only the default expert; switches start other experts on demand
  • Answers ACP initialize while OctopServer boots in the background (lean: skip IM/cron/catalog scan) so IDE “Loading…” is shorter
  • Depends on harness inbound ACP multi-expert + lifecycle + async resolve_harness

Depends on

Visual proof

Zed session expert picker listing multiple local Octop agents after octop acp (no --agent):

Zed multi-expert picker

Test plan

  • tests/unit/cli/test_acp_cmd.py
  • pre-commit make precommit (format + lint + typecheck + tests + dashboard build)
  • Visual: Zed expert dropdown lists many local agents
  • After harness feat: expose the active search source in search settings (#109) #114 is available: switch expert in Zed starts the other agent on demand
  • Cold open: Loading ends before full agent ready; first prompt still waits for default expert

List all local experts for IDE selection, boot only the default, answer
initialize before runtime is ready, and start other experts on demand.
@jubaoliang

Copy link
Copy Markdown
Collaborator

🔍 Automated Review Findings

  • ❌ CI Workflow failed: fix the failing checks before requesting re-review
  • 🧱 No test changes detected: add tests for new features, regression tests for bug fixes

Please address the above and @ me for re-review.

@jubaoliang

Copy link
Copy Markdown
Collaborator

⚠️ Correction to previous automated check: tests/unit/cli/test_acp_cmd.py was detected after re-check. Only the CI failure item above applies. Apologies for the noise.

@jubaoliang

Copy link
Copy Markdown
Collaborator

🔍 Automated Review Findings

  • ❌ CI Workflow failed: fix the failing checks before requesting re-review

Please address the above and @ me for re-review.

…encentCloud#114

PyPI octop-harness 1.0.6 still lacks experts/resolve_harness; type: ignore
keeps Octop CI green while Depends-on TencentCloud/octop-harness#114.
@huangcheng

Copy link
Copy Markdown
Contributor Author

@jubaoliang CI was failing typecheck because run_harness_acp_server(..., experts=, resolve_harness=) is not on PyPI yet (still open as TencentCloud/octop-harness#114; 1.0.6 does not include it). Also had a CHANGELOG conflict with develop after 1.0.3b2.

Pushed a0b728d:

Please re-review once CI is green. After harness #114 is released, we should remove the ignore and pin that harness version.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants