Repository navigation
fix(teams): load persisted members before host startup and reload - #2476
Open
xyi74976-del wants to merge 1 commit into
Open
xyi74976-del wants to merge 1 commit into
xyi74976-del wants to merge 1 commit into
Conversation
xyi74976-del
marked this pull request as ready for review
October 29, 2026 05:47
9 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2467. CLI creation persists experts through a separate embedded runtime. The running Dashboard keeps its earlier harness registry, so a valid new team can return an empty
agent_listand fail peer resolution. Updating an avatar merely triggers a reload; the avatar values are unrelated.Load missing eligible roster experts before the team host starts or reloads. Keep existing instances and recheck the current host, member, roster, state and ownership/sharing permissions inside the member lifecycle lock. Explicitly stopped, disabled, deleted, private or nested-team entries remain unloaded; two null owner IDs do not establish ownership.
Related #2471 changes first-invocation loading. This regression occurs during peer discovery before a member can be invoked.
Target branch and change type
Verification
make all PYTEST_JOBS=2with--dist=loadfile: 5,313 passed, 35 skipped; Ruff and strict mypy passed. The backend/test blobs were unchanged through the subsequent upstream CSS-only synchronization to44c22434.Native Windows, live providers, a real operator database and an interactive Dashboard end-to-end run were not tested. Existing dependency deprecation warnings remain. Hosted CI is separate and is not claimed as passed.
Evidence and review
Evidence boundaries. The screenshot renders actual local test summaries; it is not a product UI capture or human-review attestation.
Codex assisted investigation, implementation, tests, independent AI review and this description. Contributor review confirmed for
8f5551469740a17f65376cb22499f2312f054210on 2026-10-29.Hosted checks
At current head
8f5551469740a17f65376cb22499f2312f054210, the CodeCC scan passed. The upstream CI workflow is awaiting maintainer approval (action_required); its test jobs have not executed. Local results above are separate from hosted CI. The contributor has confirmed review of this exact revision.