Repository navigation
feishu_bot_creator.py: add timeout to urllib.request.urlopen calls - #2655
Closed
TrueFurina wants to merge 1 commit into
Closed
TrueFurina wants to merge 1 commit into
TrueFurina wants to merge 1 commit into
Conversation
Two urllib.request.urlopen() calls in the Feishu greeting flow had no timeout. If the open.feishu.cn endpoint is unreachable (network partition, DNS stall, or TLS handshake timeout), the call blocks the bot creator indefinitely: 1. POST /auth/v3/tenant_access_token/internal — fetch tenant token 2. POST /im/v1/messages — send the initial greeting message Both are wrapped in broad except Exception blocks, so adding timeout=30 lets the except path take over on network failures instead of deadlocking. The sibling yuanbao_bot_creator already uses timeout=30 for the same endpoint family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timeout to urllib.request.urlopen calls in feishu_bot_creator
Two urllib.request.urlopen() calls in the Feishu greeting flow had
no timeout. If the open.feishu.cn endpoint is unreachable (network
partition, DNS stall, or TLS handshake timeout), the call blocks the
bot creator indefinitely:
Both are wrapped in broad except Exception blocks, so adding
timeout=30 lets the except path take over on network failures instead
of deadlocking. The sibling yuanbao_bot_creator already uses timeout=30
for the same endpoint family.