Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The menu item availability guard skips the .visible setting on macOS 26.x.
Pull request overview
Raises the app’s minimum supported macOS version to 26 and updates related tooling, documentation, and CI.
Changes:
- Updates deployment targets and BuildTools platform requirements.
- Removes obsolete compatibility handling.
- Updates Xcode schemes, CI, and README for macOS 26/Xcode 27.
File summaries
| File | Summary |
|---|---|
TextGrabber2/Sources/Extensions/NSPasteboard+Extension.swift |
Removes obsolete pasteboard availability handling. |
TextGrabber2/Sources/Extensions/NSMenuItem+Extension.swift |
Uses native menu image visibility APIs. |
TextGrabber2/Sources/App/App+Detection.swift |
Simplifies menu symbol rendering. |
TextGrabber2.xcodeproj/xcshareddata/xcschemes/TextGrabber2.xcscheme |
Updates Xcode scheme metadata. |
TextGrabber2.xcodeproj/xcshareddata/xcschemes/TextGrabber2 (zh-Hans).xcscheme |
Updates Xcode scheme metadata. |
TextGrabber2.xcodeproj/xcshareddata/xcschemes/TextGrabber2 (en).xcscheme |
Updates Xcode scheme metadata. |
TextGrabber2.xcodeproj/project.pbxproj |
Sets the deployment target to macOS 26. |
README.md |
Documents macOS 26 support. |
BuildTools/Package.swift |
Sets the package platform minimum to macOS 26. |
.github/workflows/build.yml |
Updates the CI toolchain and destination. |
Review details
Suppressed comments (1)
TextGrabber2/Sources/Extensions/NSMenuItem+Extension.swift:28
- With the deployment target now set to macOS 26, this call should also run on 26.x. The availability guard above still skips it until macOS 27, so menu item images on the newly supported 26.x runtime keep the default visibility instead of the
.visiblesetting; the previous compatibility branch invoked this selector whenever it existed. Change the guard to 26.0 (or remove it) so the setting applies to all supported systems.
preferredImageVisibility = .visible
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The CI workflow uses an unsupported xcode-27 runner label and must be corrected before approval.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.