Skip to content

fix(bundle): components as peer dep#779

Open
ShaMan123 wants to merge 1 commit into
ThatOpen:mainfrom
ShaMan123:fix/peer-deps
Open

fix(bundle): components as peer dep#779
ShaMan123 wants to merge 1 commit into
ThatOpen:mainfrom
ShaMan123:fix/peer-deps

Conversation

@ShaMan123

@ShaMan123 ShaMan123 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Description

I discovered that since components was declared as a dep on components-front it was build into it and was not external.
That means that a consumer that has both components and components-front installed will load the components bundle twice.
The real issue will surface if the consumer will upgrade the components package - components-front will override it if it is imported first due to Components.get dedup.

This seems to be the root cause of the need to cast model to any #778 and the bug in 3.4.7 version #774

It explains a lot of trouble I was having with patch-package supposedly not being applied.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ShaMan123 ShaMan123 changed the title fix(): components as peer dep fix(bundle): components as peer dep Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant