fix(release): correct repo URLs to platform_services + Node 24 - #31
Merged
Conversation
This reverts commit f357456.
…e to Node 24 The 0.4.0 publish failed npm provenance verification: package.json repository.url (and homepage/bugs) still pointed at the old engine_services repo name, which no longer matches the platform_services provenance from Actions. Point them at the current repo. Also bumps both workflows to Node 24 (Node 20 is EOL); the paired ci.yml change validates the vite build on Node 24 in this PR before the release relies on it. The preceding revert restores the get-avatar changeset so the pipeline re-cuts 0.4.0 cleanly on merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers the partial 0.4.0 release and unblocks publishing.
What happened
Merging #30 ran the release: OIDC trusted publishing worked (authenticated, built, signed provenance), but the final publish hit
npm error 422 - Error verifying sigstore provenance bundle:package.jsonrepository.urlstill saidThatOpen/engine_services, which no longer matches theplatform_servicesprovenance from Actions. So main got bumped to 0.4.0 and the changeset was consumed, but nothing published (npm still 0.3.16).This PR
f357456) so theget-avatarchangeset is restored and the pipeline can re-cut 0.4.0 cleanly.engine_services→platform_servicesURLs in package.json (repository, homepage, bugs) — the actual publish blocker.On merge
Pipeline finds the changeset, versions to 0.4.0, builds on Node 24, and publishes with matching provenance → getAvatar ships as 0.4.0.
Depends on this PR's CI (Node 24 build) passing first — if it fails, the Node 24 bump comes out and we ship on 20.