Skip to content

Fix continued_fraction for large integers and big fractions #15660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trleo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix continued_fraction for large integers and big fractions #15660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions maths/continued_fraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"""

from fractions import Fraction
from math import floor


def continued_fraction(num: Fraction) -> list[int]:
Expand Down Expand Up @@ -35,11 +34,13 @@ def continued_fraction(num: Fraction) -> list[int]:
[0, 1, 3]
>>> continued_fraction(Fraction("-2.25")) # -2.25 = -3 + 0.75
[-3, 1, 3]
>>> continued_fraction(Fraction(2**53 + 3))
[9007199254740995]
"""
numerator, denominator = num.as_integer_ratio()
continued_fraction_list: list[int] = []
while True:
integer_part = floor(numerator / denominator)
integer_part = numerator // denominator
continued_fraction_list.append(integer_part)
numerator -= integer_part * denominator
if numerator == 0:
Expand Down
Loading