refactor(network): Remove obsolete HTTP Proxy option

[githubawn]

What this code did:

The TextEntryHTTPProxy option in OptionsMenu.cpp:

1. Saved/read an HTTP proxy server address from the Windows Registry (Proxy) in HKLM\SOFTWARE\Electronic Arts\EA Games\Command and Conquer Generals Zero Hour.
2. Configured GameSpy's ghttpSetProxy() for HTTP web requests (MOTD news bulletins and patch checks).

Background & Reason for Removal:

• Scope Limitation: HTTP Proxy only affects HTTP TCP requests (web bulletins). It does not proxy peer-to-peer UDP game traffic or match sockets.
• Player Confusion: Players frequently misinterpret "Proxy" in the game options as a full network proxy to route multiplayer matches or bypass UDP firewall rules.
• GUI Cleanliness: Calling textEntryHTTPProxy->winHide(TRUE) in C++ hides the obsolete setting from the Options menu without breaking custom/legacy .wnd layout assets.
• UAC & Registry Safety: Eliminates 1 of the 4 runtime write to HKEY_LOCAL_MACHINE (HKLM) that caused Windows UAC permission failures (ERROR_ACCESS_DENIED) when playing without Administrator privileges on certain variants of Windows.

[greptile-apps]

Greptile Summary

Removes the obsolete HTTP proxy integration.

• Stops loading the registry proxy for in-game and PATCHGET HTTP requests.
• Removes proxy persistence and runtime configuration from both game options menus.
• Hides the obsolete proxy input and label in the Generals and Zero Hour interfaces.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameNetwork/GameSpy/MainMenuUtils.cpp	Removes registry-based proxy configuration before in-game patch and bulletin requests.
Core/Tools/PATCHGET/CHATAPI.cpp	Removes registry-based proxy configuration from the standalone patch downloader.
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp	Removes proxy loading and saving and hides the obsolete controls in Generals.
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp	Removes proxy loading and saving and hides the obsolete controls in Zero Hour.

_{Reviews (3): Last reviewed commit: "refactor(network): Put HTTP Proxy option..." | Re-trigger Greptile}

[xezon]

Instead of removing the http proxy port, would it be possible to repurpose is and bind net packet traffic for game messages hrough it or is that not needed or possible?

[githubawn]

Not needed IMHO.
The common desktop OSs already have this built in if a user wants it with decades of stability work.
We shouldn't add features that could increase latency for everyone else.

[tintinhamans]

Have you validated that the game actually respects the OS proxy settings? Also we should consider http_proxy and https_proxy environment variable support along with command line flags to support e.g. Linux and macOS.

[githubawn]

The original code relied on its own internal registry keys rather than OS settings; it does not follow the OS proxy settings. Will update the description.

Adding http_proxy / https_proxy support would just reintroduce player confusion (thinking it routes P2P game traffic) and unnecessary code complexity.

If someone actually needs to proxy HTTP (or UDP) traffic for this game, better system-level tools and wrappers already exist to handle that far more cleanly.

I'll be happy to add the switch if users report that they need this switch without having superior options already available.

[xezon]

Looks good

[xezon]

Can also explain why this was obsoleted.