unify(ww3d2): Merge WW3D and move it to Core#3012
Open
bobtista wants to merge 2 commits into
Open
Conversation
|
| Filename | Overview |
|---|---|
| Core/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt | Enables the centralized WW3D implementation through the Core interface source list. |
| Core/Libraries/Source/WWVegas/WW3D2/ww3d.cpp | Moves the Zero Hour WW3D implementation into Core and qualifies shared WW3D include paths. |
| Core/Libraries/Source/WWVegas/WW3D2/ww3d.h | Relocates the shared WW3D public interface without changing its contents. |
| Generals/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt | Disables the local implementation so the Generals target compiles the Core source once. |
| GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt | Disables the local implementation so the Zero Hour target compiles the Core source once. |
| scripts/cpp/unify_move_files.py | Adds commented historical entries documenting the completed WW3D unification operation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Core["Core WW3D2<br/>ww3d.cpp / ww3d.h"]
Generals["Generals g_ww3d2"]
ZeroHour["Zero Hour z_ww3d2"]
GConsumers["Generals WW3D consumers"]
ZConsumers["Zero Hour WW3D consumers"]
Core --> Generals
Core --> ZeroHour
Generals --> GConsumers
ZeroHour --> ZConsumers
Reviews (2): Last reviewed commit: "unify(ww3d2): Move WW3D to Core" | Re-trigger Greptile
bobtista
force-pushed
the
bobtista/unify/ww3d-to-core
branch
from
July 25, 2026 16:12
a0dd61d to
902892d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generals and Zero Hour differ only by comments and the disabled WWShade
SHD_FLUSHhook.Now Generals uses the Zero Hour implementation, and
ww3d.cppandww3d.hare moved to Core usingunify_move_files.pyTodo: