bugfix(texture): Fix Generals missing texture and vegetation at lowest texture resolution

[Mr-Sheerlock]

• Fixes Black terrain, textures and missing vegetation when setting lowest texture resolution in Generals #2787

In General's DDSFileClass the ReductionFactor was being set to 0 because it was compared with WW3D::Get_Texture_Min_Dimension() which is different from its meaning and use. Hence, this adjustment was removed.

Also note that this results in a difference with retail where the vegetation and assets weren't being reduced properly at the lowest setting. I confirmed that the vegetation now looks similar to Zero hour's lowest setting (as opposed to higher detail even at lowest setting in retail generals). I also didn't notice a regression at higher resolutions.

Retail Generals

Fixed Generals

[greptile-apps]

Greptile Summary

Removes the incorrect DDS mip-reduction clamp in the Generals-specific WW3D implementation, allowing the existing texture-loading pipeline to apply the requested reduction and preserve textures and vegetation at the lowest texture setting.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The main compressed-texture loading path already bounds the requested reduction against the available mip levels and minimum dimensions before constructing DDSFileClass, so removing the constructor’s incorrect secondary clamp restores the intended low-resolution behavior without exposing an invalid reduction on current paths.

Important Files Changed

Filename	Overview
Generals/Code/Libraries/Source/WWVegas/WW3D2/ddsfile.cpp	Removes a redundant, semantically incorrect comparison between mip-level count and minimum texture dimension; existing caller-side reduction validation preserves valid mip bounds.

_{Reviews (1): Last reviewed commit: "bugfix(texture): Fix Generals missing te..." | Re-trigger Greptile}

[xezon]

Nice find. Would have been implicitly fixed on game merge :-)

[Mr-Sheerlock]

Sure! If you'd like me to complete the merge of the file please do tell.