Skip to content

unify(particlesys): Merge and move W3DParticleSys to core - #3014

Merged
xezon merged 2 commits into
TheSuperHackers:mainfrom
stephanmeesters:unify/w3dparticlesys
Jul 27, 2026
Merged

unify(particlesys): Merge and move W3DParticleSys to core#3014
xezon merged 2 commits into
TheSuperHackers:mainfrom
stephanmeesters:unify/w3dparticlesys

Conversation

@stephanmeesters

@stephanmeesters stephanmeesters commented Jul 26, 2026

Copy link
Copy Markdown

Merge by rebase

This merges and moves W3DParticleSys.h and W3DParticleSys.cpp.

Generals gets:

  • Ability to render smudges (TheSmudgeManager is non-null but we don't expect to see any smudges in the data)
  • Ability to render weather effects (not used, TheSnowManager is null)
  • Removes unnecessary check for invisible particles (added to GeneralsMD to test but it never triggered a breakpoint)

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit titles need polishing

@xezon xezon added Gen Relates to Generals ZH Relates to Zero Hour Unify Unifies code between Generals and Zero Hour labels Jul 27, 2026

@Skyaero42 Skyaero42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@xezon
xezon merged commit a54d97d into TheSuperHackers:main Jul 27, 2026
16 checks passed
xezon pushed a commit that referenced this pull request Jul 27, 2026
@stephanmeesters
stephanmeesters deleted the unify/w3dparticlesys branch July 27, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen Relates to Generals Unify Unifies code between Generals and Zero Hour ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants