[HugoXK]

Written-by: Delivery-1
Fixes #2425
Owner: Delivery-1
Tip SHA: 02ff151
Branch: delivery1/workflow-edge-canonical-spec (fork HugoXK/FlyBot, base delivery/ai-centric-development-service @ 5e71a07e)

Reproduce

On the base, one fact spelled text: draft on the node and text:draft on its edge makes validateWorkflow refuse a definition that the engine can run:

cd core && node -e "
import('./src/shared/workflow.js').then(m => console.log(JSON.stringify(m.validateWorkflow({
  id: 'draft-publish', name: 'x', version: 1, inputs: [], deliverables: ['link:published'],
  nodes: [
    { id: 'draft', role: 'Writer', outputs: ['text: draft'] },
    { id: 'publish', role: 'Publisher', inputs: ['text:draft'], outputs: ['link:published'] },
  ],
  edges: [{ from: 'draft.text:draft', to: 'publish.text:draft' }], loops: [],
}).problems)))
"

Actual on base: [{"code":"edge/misaligned","message":"the edge \"draft.text:draft -> publish.text:draft\" does not line up: ..."}]. Expected: ok: true — #1291/#1298 make the parsed spec the one key for a fact (canonicalSpec), and the same definition already gets the draft → publish dependency and passes enterNode('publish', …) once the fact is present and current.

The Workflows page is where a user meets it: core/src/host/workflow-store.js:135 refuses the save as workflow/invalid with problems[0].message, and core/src/client/workflows.js:31 renders that message.

What changed

core/src/shared/workflow.js:637 compared the edge's canonical artifact (splitEndpoint → formatArtifactSpec) against the node's raw inputs / outputs with includes, while producersOf, consumersOf, dependencyEdges, input/without-producer and output/without-consumer all read those lists through canonicalSpec. The alignment check now compares canonical sets on both ends, so the spelling cannot make a valid definition fail. A genuinely crossed edge is still refused (edge/misaligned), and an edge whose artifact is not in the node's outputs is still refused.

Four files, +102/−6: core/src/shared/workflow.js (+10/−3), core/test/workflow-edge-spec.test.js (new, 41 lines), and the two generated patches/ds-bot/files/ mirrors (generate then check).

Red without the source change

core/test/workflow-edge-spec.test.js on base 5e71a07e (fix reverted, test file present):

not ok 1 - an edge lines up when its two ends spell one fact differently
  false !== true  —  [{"code":"edge/misaligned", ...}]
# tests 2 / # pass 1 / # fail 1

With the source change: # tests 2 / # pass 2 / # fail 0. The second test (a genuinely crossed edge is still refused) is green on both, so the change is not "accept every edge".

What I ran (at the tip 02ff1513)

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/workflow-edge-spec.test.js
# tests 2 / # pass 2 / # fail 0

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/workflow.test.js test/workflow-repo-dev.test.js test/workflow-preview.test.js test/workflow-doc.test.js
# tests 41 / # pass 41 / # fail 0

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test "test/*.test.js"
# tests 3161 / # pass 3154 / # fail 7

The 7 failures are the same environment group on the base tree, unrelated to this diff: test/workbench-client.test.js and test/project-runtime-setup.test.js (PTY / browser routes). With core/src/shared/workflow.js reverted to the base and the fix's test kept, those two files give # tests 32 / # pass 25 / # fail 7 — identical names and count — so they are this box, not the change. Base full run: # tests 3159 / # pass 3152 / # fail 7 (2 fewer tests: this PR's new file).

$ cd core && npm run lint
Found 105 warnings and 0 errors.        (warnings are pre-existing)
$ ARCH_DOCS_BASE=upstream/delivery/ai-centric-development-service node core/scripts/check-arch-docs.mjs
arch-docs: OK (4 changed file(s))
$ node scripts/ds-bot-patches.mjs generate && node scripts/ds-bot-patches.mjs check
ok   ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5)
ok   10 patches apply cleanly in order
ok   core/ equals ds-bot/ + patches/ds-bot/
$ cd core && node scripts/build-client.mjs --check   # exit 0 (client untouched)

git diff upstream/delivery/ai-centric-development-service...HEAD --stat lists only the four files above.

Not run

• No changelog fragment: changelog.d/ is outside this lane's file surface (core/src/shared/**, core/test/**), and the repository gate (node .github/scripts/changelog.mjs check) only validates existing fragments. The change removes a false refusal; it adds no feature. Say if the release notes want one and it can be added on top of this tip.
• No smoke test: index.js / src/host/ are untouched.

Checkpoint

{
  "pr": 2427,
  "claim": "Delivery-1",
  "issue": 2425,
  "summary": "validateWorkflow compared an edge's canonical artifact against a node's raw inputs and outputs, so one fact spelled with a space on the node and without one on the edge was refused as misaligned while producers, consumers, dependencyEdges and enterNode all keyed it by canonicalSpec. Both ends now read through canonicalSpec, so the definition validates and a genuinely crossed edge is still refused. One new test file proves both halves.",
  "files": ["core/src/shared/workflow.js", "core/test/workflow-edge-spec.test.js"],
  "checks": { "ran": "node --import ./test/harness-resolve.mjs --test test/workflow-edge-spec.test.js test/workflow.test.js test/workflow-repo-dev.test.js test/workflow-preview.test.js test/workflow-doc.test.js && node scripts/ds-bot-patches.mjs check", "result": "green", "at": "02ff1513a388ee1835f295f75d7a7e6dea4b71d6" },
  "next": "none — ready for review"
}

[HugoXK]

@Birfy review request for this exact tip: 02ff1513a3 (base 16d16456, non-draft, maintainer_can_modify: true).

Red-first on a clean base plus the four gates are in the PR body; enqueue-guard is red only because no Verifier report names this tip yet.

Please review 02ff1513a3 and post Verdict: PASS (or the changes you want). No new tip will be pushed for CI noise.

[HugoXK]

Closing: our account has no write access to ThinkFlowLab/FlyBot, so it cannot merge into delivery/ai-centric-development-service; the fix is complete and verified at 80ada66f31b8b601f0b320b9b94667473b03392b, and we will re-open it against main or this branch the moment someone with merge rights wants it.

Owner: Delivery-1
Written-by: Delivery-1