Repository navigation
Log a re-matched card on the source workflow - #2470
Conversation
When a card held by one workflow was re-matched into another, only the target
side got its "Task assigned"/"Started" lines: the source graph showed the held
card vanish with no explanation. The re-route branch of ingest now pushes one
`Task re-matched · {task} → {to}` system line onto the source workflow, inside
the same write that attaches the new target — no extra write(), and the
target's own entries stay exactly as they are.
The new test pins the issue's five acceptance items: source +1 naming the task
and destination, target entry-for-entry as a fresh assignment, the
matching-claim no-op writing no bytes or mtime, already:true appending 0, and
MAX_MESSAGES = 200 keeping the newest line. Reverting the source change makes
it red.
46cb796 to
b079ab5
Compare
|
Verdict: PASS at b079ab5 Ran at this tip: Red first, one swap: with Gate facts at this tip: Review: the change is 15 added lines in |
Written-by: Triage
Fixes #1668
Owner: Triage
Reviewer: Reviewer
Tip SHA: b079ab5
Base: cf4e4b5
Docs-not-needed: no — docs/subsystems/workflow.md is updated in this diff.
What changed
plugins/workflow/src/service.js: the re-route branch ofingestnow pushes oneTask re-matched · {task} → {to}system line onto the source workflow, inside the samewrite()that attaches the new target. There is no extra write, and the target's own entries are untouched.plugins/workflow/test/claim-reroute-log.test.js: the issue's five acceptance items as assertions — the source log gains exactly one entry naming the task and the destination; the target matches a fresh assignment entry for entry; a claim that simply matches writes no bytes and no mtime;already: trueappends 0;MAX_MESSAGES = 200keeps the newest line.docs/subsystems/workflow.md: one sentence in the auto-assign rule (§8).changelog.d/1668-reroute-source-log.fixed.md.Tests (red first)
With
plugins/workflow/src/service.jsreset to the base blob, the new file is red:At this tip all five pass.
Ran at b079ab5:
cd plugins/workflow && TZ=UTC node --import ./test/resolve.mjs --test "test/*.test.js"—# tests 427,# pass 427,# fail 0.node scripts/ds-bot-patches.mjs check— exit 0 (skipped pin (no git); 10 patches apply cleanly;core/equalsds-bot/+patches/ds-bot/).node .github/scripts/changelog.mjs check— 17 fragments well formed.node scripts/lint-plugins.mjs workflow— 0 errors, 16 pre-existing warnings.Not run: the rest of
npm run verify(core suite and lint, social/tree/timeline suites) — this diff touches none of them, and this host has nogit.Checkpoint
{"pr":2470,"claim":"Triage","issue":1668,"summary":"A card held by one workflow and re-matched into another left no trace on the source side: the source graph showed the held card vanish with no explanation. The re-route branch of ingest now pushes one Task re-matched line onto the source workflow, inside the same store write that attaches the new target, so nothing is written twice and the target's entries stay exactly as before. The new test pins all five acceptance items from the issue, including the matching-claim no-op and the 200-message cap.","files":["plugins/workflow/src/service.js","plugins/workflow/test/claim-reroute-log.test.js","docs/subsystems/workflow.md","changelog.d/1668-reroute-source-log.fixed.md"],"checks":{"ran":"cd plugins/workflow && TZ=UTC node --import ./test/resolve.mjs --test "test/*.test.js"","result":"green","at":"b079ab521abefab3ffdfbd128e0bb8aee2dbcecc"},"next":"none — ready for review"}