Repository navigation
Reconcile lost SDK controllers with durable stop and process exit evidence - #2511
Merged
Conversation
zy95-12
marked this pull request as ready for review
November 5, 2026 07:01
Collaborator
Author
|
Written-by: Codex Exact91e4e6e8f686805fb64cc23b36df75f464eb34c5 fullverify5,031/0 and samehead Node24/tests-ok green (41983744699). Pairing clear, no unresolved comments/reviews/threads, target unchanged/mergeable, actual delivery branch rules[]. enqueue-guard reports only absent independent Verifier; none is fabricated. Applying Owner standing basic-gate scope solely for delivery, with no admin/main/rule bypass. Parent stays open for the authorized baseline stage and actual onsite acceptance. |
zy95-12
merged commit Nov 5, 2026
431f040
into
ThinkFlowLab:delivery/ai-centric-development-service
9 of 13 checks passed
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Codex
Part of #2483; controller-loss stage. Keep umbrella open for Chief baseline selection and onsite acceptance.
Reconcile a lost SDK controller through the original stop-ack/process-exit contract. A resource receipt binds worker/lease/generation and process birth; EOF/EPIPE or an explicit birth-verified pidfd stop acknowledges only after SDK settles. Existing resource reconciliation aligns worker and lease, including partial releases. Trusted saved host stop/exit evidence can recover legacy records; missing acknowledgement/birth/exit remains unknown. No new service, timer, Effect kind, fixed role or Task completion.
Exact head91e4e6e8f686805fb64cc23b36df75f464eb34c5: root verify5,031/0 including eight actual disposable DSH scenarios; same-head Node24/tests-ok success run41983744699.82 affected coverage tests pass; exit helper100%lines/89.06%branches/100%functions, Harness89.64/75.82/77.78 module totals. New statements exercised, optional combinations not exhaustive. Actual pinned Codex SDK/CLI abort after pipe loss passes locally and in UID1000/cap-drop-ALL disposable Docker, with CLI/worker exit verified. Provider is a held local fixture, no paid inference. Docker8 checks include the SDK abort; unsupported CLI branch added afterward is host-tested, helper/worker sources unchanged.
Includes regression tests, long-term memory, architecture/operations, decision/changelog, canonical patches/OpenAPI. Existing policy cap and required sources retained with verbatim chronology archive. Resource runtime also needs the receipt-aware worker for future recovery; old records without actual proof cannot be declared exited retrospectively. No live service/config/profile/credential changes or private App acceptance. Self pairing clear, no independent Verifier PASS. Standing Owner delivery-only basic gate applies; actual branch rules retained.