Repository navigation
Accept merged Attempt scope after Task requirements evolve - #2549
Merged
zy95-12 merged 3 commits intoNov 5, 2026
Conversation
zy95-12
marked this pull request as ready for review
November 5, 2026 15:26
zy95-12
merged commit Nov 5, 2026
80cf579
into
ThinkFlowLab:delivery/ai-centric-development-service
13 of 14 checks passed
Closed
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Codex
Fixes #2526 (follow-up to #2537). Target:
delivery/ai-centric-development-service.After Chief revised a Task to rev3/rev4, its already merged rev2 Attempt could never be accepted: both the advisory precheck and execution applied whole-Task requirement equality. Scoped acceptance now judges the pinned Attempt definition and its exact code/test/Review/provider-merge evidence while leaving the Task open. Settlement records both original and current revisions; an explicitly chosen next Attempt uses the current requirements. Historical parent settlement also looks up the original durable child admission using the pinned parent revision; child evidence and the committed admission remain mandatory. Whole-Task closure retains its independent current-goal checks.
Chief/TaskView receive the same bounded comparison: revisions, changed fields, prior values, and the existing paged requirement source. Changes after a Chief snapshot use existing stale-snapshot correction. Prior refusal messages describe past outcomes, not current action legality. Candidate evidence, identity, permissions, execution generations, exits, pending writes and replay/rollback guards remain strict. No new workflow, timer, store, migration or automatic human escalation.
Validation:
056cb557: the corrected persisted-Task fixture fails the real Git/Runtime rev2→rev4 settlement/next-delivery path, actual Chief loop and advisory projection on the old requirement-equality guard; all three pass after the fix.1f8cff3abcaad9ccf91ebb0a7b0980c4307deae0.Not run: live OpenToday deployment/restart/state or binding edits, external provider writes, paid model inference, or a real vendor SDK/model on this new evolution path. Runtime/SDK-protocol subprocess fixtures do not establish onsite acceptance. Source preserves #2527 Feishu integration.