Skip to content

Accept merged Attempt scope after Task requirements evolve - #2549

Merged
zy95-12 merged 3 commits into
ThinkFlowLab:delivery/ai-centric-development-servicefrom
zy95-12:fix/2526-evolving-requirements
Nov 5, 2026
Merged

zy95-12 merged 3 commits into
ThinkFlowLab:delivery/ai-centric-development-servicefrom
zy95-12:fix/2526-evolving-requirements

Conversation

@zy95-12

@zy95-12 zy95-12 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Codex

Fixes #2526 (follow-up to #2537). Target: delivery/ai-centric-development-service.

After Chief revised a Task to rev3/rev4, its already merged rev2 Attempt could never be accepted: both the advisory precheck and execution applied whole-Task requirement equality. Scoped acceptance now judges the pinned Attempt definition and its exact code/test/Review/provider-merge evidence while leaving the Task open. Settlement records both original and current revisions; an explicitly chosen next Attempt uses the current requirements. Historical parent settlement also looks up the original durable child admission using the pinned parent revision; child evidence and the committed admission remain mandatory. Whole-Task closure retains its independent current-goal checks.

Chief/TaskView receive the same bounded comparison: revisions, changed fields, prior values, and the existing paged requirement source. Changes after a Chief snapshot use existing stale-snapshot correction. Prior refusal messages describe past outcomes, not current action legality. Candidate evidence, identity, permissions, execution generations, exits, pending writes and replay/rollback guards remain strict. No new workflow, timer, store, migration or automatic human escalation.

Validation:

  • Fresh base 056cb557: the corrected persisted-Task fixture fails the real Git/Runtime rev2→rev4 settlement/next-delivery path, actual Chief loop and advisory projection on the old requirement-equality guard; all three pass after the fix.
  • Final-head related suites: 281 passed / 0 failed; the final actual Chief loop also passes with four historical same-fact refusal records. It sees legal scoped acceptance, accepts rev2, keeps Task open and explicitly starts rev4. New stale-judgement regression returns correction without blocking the Task or consulting a human.
  • Preserved negative coverage for mutated candidate/evidence, provider/rights/exit failures, changed requirements during I/O and incomplete whole-Task acceptance. Role budget 6/0, API/OpenAPI 10/0. Self-review also reproduced and repaired the child-admission revision barrier; targeted parent/evolution/Chief/negative admission regressions: 5/0. Final-head full root verification: 5167 passed / 0 failed, including 8 actual DSH runtime checks. GitHub Test 42053449199, attempt1: final-head Node24 / tests-ok both success.
  • Measured broad coverage (whole modules): shared helper 100% lines / 99.25% branches / 100% functions; Chief 96.96/85.56/80.18; Delivery 96.91/79.74/86.67. This is not a 100% added-branch claim; unexecuted helper ranges include queue.reason null fallback, direct missing-candidate shortcircuit, and the new advisory prior-value empty-string fallback. The latter cannot authorize an action and the original full requirement remains queryable. No added source line appears in the Node uncovered-line list; that is not proof of every added branch combination. No exclusions or weakened evidence assertions.
  • Updated compact long-term memory, delivery/Chief/backend architecture, API/OpenAPI, decision, changelog and canonical mirrors. Original context cap/source list unchanged. Broader mandatory-context slimming stays separately deferred.
  • Pairing self-review covered correctness, security and conventions; no independent Verifier PASS claimed. Final source: 1f8cff3abcaad9ccf91ebb0a7b0980c4307deae0.

Not run: live OpenToday deployment/restart/state or binding edits, external provider writes, paid model inference, or a real vendor SDK/model on this new evolution path. Runtime/SDK-protocol subprocess fixtures do not establish onsite acceptance. Source preserves #2527 Feishu integration.

@zy95-12
zy95-12 marked this pull request as ready for review November 5, 2026 15:26
@zy95-12
zy95-12 merged commit 80cf579 into ThinkFlowLab:delivery/ai-centric-development-service Nov 5, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant