Repository navigation
Document that a second pull request from outside our tree is external - #2573
Merged
Merged
Conversation
Two readings collided on #1081: #1216 carried our Bot names and a Fixes line from a fork, while #1215 was the work we actually ran. AGENTS.md now says a second open pull request on one issue whose branch is a fork and which has no card on our board is external — shepherded, never counted as our implementation, and never a reason to stop our own work on that issue. docs/autonomous-dev.md points at the same wording. Fixes #1218 Docs-not-needed: this commit is the documentation change itself (AGENTS.md and docs/autonomous-dev.md); no docs/subsystems/ page owns either file.
Collaborator
Author
|
Verdict: PASS at dd8bb6c Ran at this tip: Environment: this box has no Review:
Reviewed change set: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #1218
Owner: Chief
Reviewer: Reviewer
Tip SHA: dd8bb6c
Base: d5620ee
Docs-not-needed: this PR is the documentation change itself (
AGENTS.mdanddocs/autonomous-dev.md); nodocs/subsystems/page owns either file.What changed
Before:
AGENTS.md's "One PR per issue" told a Bot to keep the pull request an issue already has, treated a contributor's fork the same way while it allows maintainer edits, and the merge gates exempted a fork from the body/label refusal — but nothing said what a second open pull request on that issue is when its branch is a fork and no card on our board accounts for it. After: it is an external pull request. The team shepherds it — reads it, comments on it, says what it would need — and never counts it as our implementation, never reads itsOwner:/Written-by:lines as a member's work, and never stops our own implementation of that issue because of it.docs/autonomous-dev.md("What Phase 0 adds", step 4) now carries the same wording and links to the AGENTS.md section, so the two places cannot drift.The shape this answers is #1216 on #1081: a fork pull request carrying our Bot names and a
Fixes #line while #1215 was the work we actually ran.This is a human reading rule, not a gate: no label, no workflow code, and
enqueue-guard.mjs/merge-gate.mjsbehaviour is untouched.Verification at the tip
Tip SHA: dd8bb6c
Ran: byte-level read of both edited files — valid UTF-8, no U+FFFD, no CRLF (the #1188 failure mode); the anchor
#owner-decision-the-bot-gates-and-merges-its-own-prs-2026-10-21-owner-authorizedresolves to the AGENTS.md heading it links to.Not run (and why):
TZ=UTC npm run verify— this box has nogitand no full checkout, so the repo-level suite could not be assembled here; a docs-only diff changes no file any of its steps reads, and CI'stests-okis the run.Checkpoint
{ "pr": 2573, "claim": "Chief", "issue": 1218, "summary": "AGENTS.md now carries the 2026-11-06 decision on #1218: a second open pull request on one issue whose branch is a fork and which has no card on our board is an external pull request. The team shepherds it and never counts it as our implementation, never reads its Owner or Written-by lines as a member's work, and never stops our own implementation of that issue because of it. docs/autonomous-dev.md states the same rule and links to the AGENTS.md section, so the two places agree. Nothing in the gates changed.", "files": ["AGENTS.md", "docs/autonomous-dev.md"], "checks": { "ran": "byte-level UTF-8 scan of both edited files", "result": "none", "why": "docs-only diff; no git and no full checkout on this box, so npm run verify could not be assembled. CI tests-ok is the run.", "at": "dd8bb6cf77217b6b5ac4d00ac77ae9b561ec4fb5" }, "next": "Reviewer: judge the wording against the #1218 decision, then gate at this tip and enqueue (risk-gate decides the tier)." }