Repository navigation
[Feat] Find desktop click targets with Jev Box (--box-target) instead of hand-written --pixel-target - #113
Draft
Birfy wants to merge 1 commit into
Draft
[Feat] Find desktop click targets with Jev Box (--box-target) instead of hand-written --pixel-target#113Birfy wants to merge 1 commit into
Birfy wants to merge 1 commit into
Conversation
Locate unknown desktop click targets each step with hosted Jev 1.14 Box (gated by noul presence and box confidence), click the box centre with the same capture binding as --pixel-target. Adds BoxQuestion/Box to the decision-model layer, offline fake-transport tests, and a small measure_box_targets helper. Depends on #97 / issue-97-jev-images.
Birfy
commented
Nov 5, 2026
Birfy
left a comment
Collaborator
Author
There was a problem hiding this comment.
Self-review (Birfy; cannot approve own PR).
Ready-to-merge-from-my-side once the stack is ready: the #98 slice looks correctly scoped on top of #99 (issue-97-jev-images). --box-target is opt-in, gated by presence noul + Box confidence (defaults clearly marked uncalibrated), --pixel-target stays, and Jev 1.14 + S1A_JEV_IMAGES usage errors are the right hard gates. BoxQuestion / Box on the decision-model types, locate_box_targets binding to the current capture, and the new unit tests are what I wanted for an experimental path.
What's left before leaving draft / merge:
- Depends on #99 merging first (base is
issue-97-jev-images). - Live #30 visual fixture measurement (or maintainer exemption) — still blocked without TypeSafe images +
jev-1.14.0on a machine that can run the desktop fixture; offline tests alone are fine for draft, not for a quality claim. - Keep the docs/experimental wording; do not imply calibrated thresholds until
scripts/measure_box_targets.pyhas a real capture run recorded.
No code-change request from this pass; CI green (core/full/benchmarks). Stay draft until (1)+(2).
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required human contributor answers
Per the repository owner's standing instruction (Danyang, 2026-10-14) for scheduled agent runs, these are filled from issue #98 rather than waiting for separate human answers.
What outcome are you trying to achieve?
Answer: Locate unknown desktop controls via Jev Box instead of hand-written
--pixel-targetcoordinates ([Feat] Find desktop click targets with Jev's Box question instead of hand-written --pixel-target coordinates #98).What is the highest-leverage variable for that outcome?
Answer: Noul presence + Box confidence–gated targets offered each step, with Box answering only where.
How will this work move that variable rather than create busywork?
Answer: Replaces hand-written
--pixel-targetfor unknown layouts; choice among offered actions stays the existing decision step.Who is the customer or user, and what do they actually need?
Answer: Desktop agent users clicking controls without accessibility entries or known coordinates.
After answering the four questions: is a PR needed at all to achieve this outcome?
Human decision and rationale (or explicit source reference): Yes; issue #98 scopes one feature PR after #97 lands. This PR's base is
issue-97-jev-images(PR #99) so the diff is only #98 work.For a bug fix: link actual observed failure evidence.
Evidence: Not a bug fix.
Why
Desktop screenshot actions need hand-written
--pixel-targetcoordinates today. That fails for apps whose layout is unknown in advance. Jev 1.14's Box question returns where something is; TypeSafe's pattern is to gate it with a presencenoulbecause Box always returns a box.How
Depends on #97 / PR #99 (
S1A_JEV_IMAGES, danger-zone header). Open first:s1a/desktop/env.py—locate_box_targets, gatedbox:candidates, centre click with capture bindings1a/agents/desktop.py—--box-target, Jev 1.14 + images usage errors, uncalibrated thresholdss1a/decision_models/types.py/validation.py/jev.py—BoxQuestion/Boxs1a/tool/models.py— locate before the choice decision; record box on the ticktests/test_desktop_box_target.py,scripts/measure_box_targets.pyWhat
--box-target KEY=description(experimental).S1A_BOX_PRESENCE_THRESHOLD/S1A_BOX_CONFIDENCE_THRESHOLD(default0.5, uncalibrated).--pixel-targetunchanged;--box-targetrequires--model jev,S1A_JEV_IMAGES=1,TYPESAFE_MODEL=jev-1.14.0+.Verification
ruff format --check/ruff check/ty check: pass (box env used pip workaround for gitcodeintelli-router418; same as prior weekday runs).pytest -q: 1364 passed, 132 skipped (7 new intests/test_desktop_box_target.py).scripts/smoke.shnot run here (uv syncblocked on gitcode); CI runs it.CHANGELOG.mdand docs updated.Demo / evidence
jev-1.14.0(no key/GPU on this agent box). Offline unit tests + docs ship; PR stays draft until a fixture run or maintainer exemption.evals/desktop/visual.md.efae4c3on baseissue-97-jev-images(8ec00f9).Closes #98