Skip to content

report.json: record the base exit floor beside fail_policy.fail_on #1081

Open

Description

@pengfei-threemoonslab

Deferred by the engineering-review implementation loop from #1074 (issue #1024).

Problem

After #1074 the exit code of verify is floored by the base manifest's declared ci.fail_on when --fail-on is absent. The floor is explained only in verifier.json base_notes. A consumer reading report.json alone sees fail_policy.fail_on: [] beside would_fail_ci: true and exit_code: 20 with no stated reason.

Evidence

Proposed fix

Record the effective exit list in the fail_policy block (for example exit_fail_on or exit_fail_on_floor), additive, with a report schema minor bump and the usual STABILITY note, subject to CONTRIBUTING § Surface discipline (the headline metric: a consumer can explain the exit code from report.json alone).

Acceptance criteria

  • report.json states the severities that decided the exit code when they differ from fail_policy.fail_on.
  • Schema regenerated; STABILITY migration note; existing consumers unaffected.

Source

Engineering review 2026-10-12 follow-up (PR #1074 review cycle 3). Tracked in #1060.

Activity

  1. added
    enhancementNew feature or request
    P2Queued; valuable but not blocking
    area:verifyverify / preview orchestration and SHIP-VERIFY-* checks
    engineering-reviewFiled from the 2026-10-12 comprehensive engineering review
    on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Queued; valuable but not blockingarea:verifyverify / preview orchestration and SHIP-VERIFY-* checksengineering-reviewFiled from the 2026-10-12 comprehensive engineering reviewenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions