Repository navigation
feat: register states and list pipeline behaviors without reflection - #643
Merged
StevenTCramer merged 5 commits intoOct 12, 2026
Merged
StevenTCramer merged 5 commits into
StevenTCramer merged 5 commits into
Conversation
AddTimeWarpState scanned assemblies, and the middleware log walked interfaces. Both kept trim suppressions in an IsAotCompatible library. The clone generator now emits TryAddTransient<T>, and a pipeline generator records behavior definitions so the log matches closed registrations. Co-Authored-By: Grok <noreply@x.ai>
Apply runs each assembly's module constructor first; docs and GetComponentOrder remarks cover the review notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fter 2 rounds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StevenTCramer
deleted the
task/104-remove-remaining-reflection-from-timewarpstate-ens
branch
October 12, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddTimeWarpStateapplies source-generatedTryAddTransient<T>()registrars.LogTimeWarpStateMiddlewarematches closed behavior registrations against definitions recorded byPipelineBehaviorRegistrySourceGenerator.TimeWarp.Stateno longer suppresses trimming or AOT warnings. No public API was removed. Redux DevTools stays deleted (task 112).Review disposition
CompilationProvidershape. M6 wontfix: theprivate protectednaming gap predates this task (097) and belongs to the clone generator.StateRegistrationRegistry.ApplyrunsRuntimeHelpers.RunModuleConstructorbefore applying registrars, release notes andcloning.mdlist the behavior changes and the generator requirement,GetComponentOrderremarks, and the pipeline generator checks that the registry type exists.review/review-framework.md,review/round-1/(general, merged),review/round-2/(general, merged),review/disposition.md.Test plan
Smoke:
Expect: the Release build reports zero IL2xxx/IL3xxx warnings.
rgprints onlyconfigureTimeWarpStateOptionsAction?.Invokeinservice-collection-extensions.add-timewarp-state.cs. Both test projects pass, including nested, generic-base, closedICloneable, and host-registration cases, plus the middleware order log.ganda repo auditexits 0.Kanban task 104
Session: Grok Bot