Repository navigation
fix: show the TimeWarp mark as the DevTools inspector favicon - #652
Merged
StevenTCramer merged 5 commits intoOct 16, 2026
Conversation
The inspector tab fell back to a globe because the host page declared no icon and the published app shipped none. Link the shared brand PNG into the inspector static assets and point the dev manifest at that original so the packed tools folder serves it. Co-Authored-By: Grok 4.7 <noreply@x.ai>
Co-Authored-By: Grok 4.7 <noreply@x.ai>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StevenTCramer
deleted the
task/123-give-the-state-devtools-inspector-the-timewarp-fav
branch
October 16, 2026 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The inspector tab icon is
assets/logo.png, the same 64×64 TimeWarp mark timewarp.software uses.App.razorlinks it as<link rel="icon" type="image/png" href="logo.png" />after<base href="/" />. The project links that file into static web assets and points the asset's content root atassets/, so development and publish both serve the original. There is no second copy underwwwroot.assets/logo.svgis not linked. It is the wide TIMEWARP ENTERPRISES wordmark. At 16 px and 32 px, on white and on near-black, it shrinks to a speck. The PNG stays readable at those sizes.InspectorFavicon_Should.ServeTheBrandPngFromTheHostPagereads the host page head and requests/logo.png.PackagedDevToolsApp_Should.StartFromAnOutOfTreeAppHostchecks the nupkg liststools/wwwroot/logo.pngwith the original bytes, then starts the packaged inspector and requests the same URL.Review
The review ran one round at effort 1 with one
generalreviewer. Final counts: bug 0, suggestion 0, nit 1 (wontfix), open 0. Disposition:accepted-exceptions.M1 is a nit.
PointDevToolsFaviconAtBrandFilematches any static web asset whose path ends withassets/logo.png, including assets from referenced projects. Today it hits only the brand file. It was marked wontfix as latent only. Tighten it to the exact path if the target is touched again.During review, the DevTools tests passed (99/99),
dotnet buildof the inspector had 0 errors with no warnings in changed files, andganda repo auditpassed. The proof gate asks for 0 warnings. It is not met repo-wide, because master already has warnings in files this change does not touch.Paths:
review/review-framework.mdreview/round-1/general.mdreview/round-1/merged.mdreview/disposition.mdTest plan
Smoke: From a clean browser profile, run the inspector (
dotnet runonsource/timewarp-state-devtools, or the packaged dll fromTimeWarp.State.DevTools.Apptools/with that directory as the working directory). Open/. Hard-refresh once so a cached globe is not reused.Expect: The document head contains
<link rel="icon" type="image/png" href="logo.png">.GET /logo.pngreturns 200 withContent-Type: image/pngand the bytes ofassets/logo.png. The tab icon is the purple and blue infinity mark with the green swoosh, on both light and dark browser chrome. There is no SVG, ICO, or apple-touch icon link.Kanban task 123