Skip to content

🔨 Add mypy type check to wsireader files - #1185

Merged
shaneahmed merged 7 commits into
developfrom
mypy-wsireader
Nov 10, 2026
Merged

shaneahmed merged 7 commits into
developfrom
mypy-wsireader

Conversation

@Jiaqi-Lv

@Jiaqi-Lv Jiaqi-Lv commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

mypy type check now covers all files under wsireader/ except base.py.

TODO: Improve test coverage.

@Jiaqi-Lv Jiaqi-Lv self-assigned this Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.91%. Comparing base (dd79833) to head (8265f14).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1185   +/-   ##
========================================
  Coverage    99.91%   99.91%           
========================================
  Files          116      116           
  Lines        13567    13578   +11     
  Branches      1622     1624    +2     
========================================
+ Hits         13556    13567   +11     
  Misses           5        5           
  Partials         6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiaqi-Lv Jiaqi-Lv added enhancement New feature or request dev tools Changes/Updates in Development tools labels Nov 6, 2026
@Jiaqi-Lv
Jiaqi-Lv requested a review from shaneahmed November 6, 2026 10:37
@Jiaqi-Lv
Jiaqi-Lv marked this pull request as draft November 6, 2026 10:56
@Jiaqi-Lv
Jiaqi-Lv marked this pull request as ready for review November 6, 2026 12:26
Comment thread tiatoolbox/wsicore/wsireader/types.py Dismissed
Comment thread tiatoolbox/wsicore/wsireader/base.py Dismissed
Comment thread tiatoolbox/wsicore/wsireader/base.py Dismissed
Comment thread tiatoolbox/wsicore/wsireader/base.py Dismissed
@Jiaqi-Lv

Jiaqi-Lv commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

@shaneahmed This PR is ready for review.

@shaneahmed shaneahmed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed
shaneahmed merged commit 58c0472 into develop Nov 10, 2026
38 checks passed
@shaneahmed
shaneahmed deleted the mypy-wsireader branch November 10, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev tools Changes/Updates in Development tools enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants