Conversation
Verified against glam 0.30.10: the Interpolate impls compile unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A downstream consumer is moving its workspace to 0.33 to line up with a `[patch]` onto a fork carrying portable archived `rkyv` types. Any version this crate does not accept forces a second `glam` into that graph, since patching removes the crates.io copy as a resolution candidate for everyone else. No code change: 0.33 gates the numeric types behind features, but `default` still enables `all-types` and the dependency here uses default features. 12 tests pass with `--features glam` at both 0.30.10 and 0.33.3.
MarijnS95
changed the title
glam version range to >=0.10, <0.34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking PR for the
glam-0.30branch, which has been pinned by a consumer for a while without one - so this also covers the two commits already on it, the manualInterpolateimpls for quaternions (slerp rather than lerp) and the cubic-hermite implementation carried over from before the fork.The version bump itself: a consumer is moving its workspace to 0.33 to line up with a
[patch]onto a fork carrying portable archivedrkyvtypes, and any version this crate does not accept forces a secondglaminto that graph, since patching removes the crates.io copy as a resolution candidate for everyone else.No code change is needed - 0.33 gates the numeric types behind features, but
defaultstill enablesall-typesand the dependency here uses default features. The 12 tests pass with--features glamat both ends of the range, 0.30.10 and 0.33.3.The branch name is now a misnomer; left as-is because it is pinned by rev elsewhere.