Skip to content

配对 Touch Control 与正式 JS-FFI 0.2.10 - #47

Merged
tiye merged 2 commits into
mainfrom
migrate/touch-jsffi0342-1102
Nov 3, 2026
Merged

tiye merged 2 commits into
mainfrom
migrate/touch-jsffi0342-1102

Conversation

@tiye

@tiye tiye commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

使用者影响:候选 0.0.37 配对正式 Calcit / @calcit/procs 0.34.2 与 JS-FFI 0.2.10。消费者需协调完整模块图,严格安装不应混用 JS-FFI 0.2.9 和 0.2.10;不移动旧 tag。

本次仅更新依赖、版本和说明,Snapshot 与已发布 0.0.36 字节一致,ControlState/ControlDelta、回调、受检 PointerEvent 与 HUD 保持。已有明确 Struct 的状态不重复包装 union。

本地 Caps strict/toolchain、Yarn immutable、全部定义、完整 strict(diagnostics=[])、原 1 项 unit、deprecated-call=0、dynamic-method=0 和构建通过。原类型门禁、npm 依赖、工作流和部署路径保持,不新增检查脚本。PR 原流程仅保留构建 artifact,不上传 COS 或执行生产部署。

待新精确 CI 和消费者验收。本轮未重新进行浏览器或移动设备交互验收,不以历史结果代替候选证据。不合并或发版。

Summary by CodeRabbit

  • Updates
    • Updated the candidate version to 0.0.37 and its JS-FFI compatibility to 0.2.10.
    • Strict installs should use one JS-FFI version and avoid mixing 0.2.9 with 0.2.10.
    • Snapshot and listed control APIs and behaviors remain unchanged.
  • Validation
    • Local validation was completed; browser and mobile acceptance testing has not been repeated for this candidate.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b5724796-7401-482b-b081-3d3a068c0382
Commits

Reviewing files that changed from the base of the PR and between 4442c9c and e8cfd0f.

Files selected for processing: 1
  • README.md
Walkthrough

The package candidate version changes from 0.0.36 to 0.0.37, and the JS-FFI dependency changes from 0.2.9 to 0.2.10. The README records compatibility guidance, local validation results, and pending browser and mobile acceptance.

Changes: Candidate Version Update

Layer / File(s) Summary
Candidate version, dependency, and status
deps.cirru, package.json, README.md
The package version changes to 0.0.37, and the JS-FFI dependency changes to 0.2.10. The README records compatibility guidance, local validation results, and that browser and mobile acceptance has not been repeated for this candidate.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

  • Triadica/touch-control#46: PR #46 set candidate 0.0.36 with JS-FFI 0.2.9; this PR updates the same candidate version and dependency pairing.
Merge Risk: Minimal · previous review 4442c

No concrete merge-blocking defect is established. Consumers must coordinate the JS-FFI upgrade; browser and mobile acceptance remain pending, so this assessment does not establish release readiness.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题明确说明了本次变更的主要内容:将 Touch Control 与正式 JS-FFI 0.2.10 配套。该内容与依赖更新和 0.0.37 候选版本变更一致。
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1
deps.cirru-5-5: 1

5-5: Minor · Potential issue · Heavy lift

Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.

Changing the dependency to JS-FFI 0.2.10 may leave a consumer that also requires 0.2.9 with a mixed module graph; the README explicitly warns that strict installs should not mix those versions.

The consumer's strict installation or subsequent build may fail instead of accepting the upgraded package.

This can occur when: A consumer upgrades touch-control to 0.0.37 while retaining a direct or transitive JS-FFI 0.2.9 requirement.

Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 967b35dc-1508-4c72-bedf-e10222b2d97c
Commits

Reviewing files that changed from the base of the PR and between 2b77608 and 4442c9c.

Files selected for processing: 3
  • README.md
  • deps.cirru
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@tiye
tiye merged commit 2730372 into main Nov 3, 2026
2 checks passed
@tiye
tiye deleted the migrate/touch-jsffi0342-1102 branch November 3, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant