Skip to content

升级 Touch Control 到 Calcit 0.42.1 并细化摇杆原点类型 - #54

Merged
tiye merged 1 commit into
mainfrom
migrate/touch-control-calcit-0421
Nov 12, 2026
Merged

tiye merged 1 commit into
mainfrom
migrate/touch-control-calcit-0421

Conversation

@tiye

@tiye tiye commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

用户影响

从源码构建请配对 Calcit 和 @calcit/procs 0.42.1。摇杆位移和回调格式保持原样。直接写入左右摇杆内部原点 Ref 的代码需要提供两个数字组成的坐标对。

改动和验证

  • 左右原点用 Tuple Number Number 表达,通过解构读取坐标,去掉按索引读取的原语。补齐新版推导出的 effect。
  • 本地完整 strict、43 个定义、原坐标测试和生产构建均通过。用合成事件执行了生成 JS 的两侧摇杆按下及移动处理器,两侧都得到预期位移。

Summary by CodeRabbit

  • Chores
    • Updated the project toolchain requirement to version 0.42.1. The README’s guidance for Calcit 0.37.0 and the stated JavaScript FFI version remain unchanged.
  • Updates
    • Touch-control pointer movement now uses coordinate pairs for its origin values. No change to the documented compatibility guidance is included.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The project updates its Calcit toolchain requirement to 0.42.1. Touch-control declarations add feature metadata, and pointer origin references and handlers now use two-number tuples.

Changes: Toolchain and pointer updates

Layer / File(s) Summary
Align Calcit toolchain versions
README.md, deps.cirru, package.json
The README, dependency declaration, and package manifest specify version 0.42.1.
Update pointer origins and feature declarations
calcit.cirru
The left and right pointer origins use two-number tuples, which the handlers destructure to calculate movement. Several functions add :state or :io to their declared features.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • Triadica/touch-control#51: This PR changes movement-related coordinate types to tuples; this PR applies the tuple contract to pointer origin references and handlers.
Merge Risk: Minimal · up to 6ad9f

This change upgrades the Calcit toolchain and refines the joystick origin types. Joystick behavior is described as unchanged, and no merge-blocking risk is identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "升级 Touch Control 到 Calcit 0.42.1 并细化摇杆原点类型" (Upgrade Touch Control to Calcit 0.42.1 and refine joystick origin types) matches the main changes. The summary shows the Calcit version bump in …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "升级 Touch Control 到 Calcit 0.42.1 并细化摇杆原点类型" (Upgrade Touch Control to Calcit 0.42.1 and refine joystick origin types) matches the main changes. The summary shows the Calcit version bump in deps.cirru, package.json, and README, plus the change of *left-origin and *right-origin from Ref (List Number) to Ref (Tuple Number Number). The objectives also confirm both parts. The title is concise, specific, and written in the repository's language, and it names both the main upgrade and the origin type refinement.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7162294a-2230-46cb-8c92-894ac23f2df4
Commits

Reviewing files that changed from the base of the PR and between 7f0d5c8 and 6ad9fc7.

Files ignored due to path filters: 1

  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 4

  • README.md
  • calcit.cirru
  • deps.cirru
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@tiye
tiye merged commit 9cf6c69 into main Nov 12, 2026
2 checks passed
@tiye
tiye deleted the migrate/touch-control-calcit-0421 branch November 12, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant