You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated the project toolchain requirement to version 0.42.1. The README’s guidance for Calcit 0.37.0 and the stated JavaScript FFI version remain unchanged.
Updates
Touch-control pointer movement now uses coordinate pairs for its origin values. No change to the documented compatibility guidance is included.
No actionable comments were generated in the recent review.
Walkthrough
The project updates its Calcit toolchain requirement to 0.42.1. Touch-control declarations add feature metadata, and pointer origin references and handlers now use two-number tuples.
The README, dependency declaration, and package manifest specify version 0.42.1.
Update pointer origins and feature declarations calcit.cirru
The left and right pointer origins use two-number tuples, which the handlers destructure to calculate movement. Several functions add :state or :io to their declared features.
Triadica/touch-control#51: This PR changes movement-related coordinate types to tuples; this PR applies the tuple contract to pointer origin references and handlers.
Merge Risk: Minimal · up to 6ad9f
This change upgrades the Calcit toolchain and refines the joystick origin types. Joystick behavior is described as unchanged, and no merge-blocking risk is identified.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "升级 Touch Control 到 Calcit 0.42.1 并细化摇杆原点类型" (Upgrade Touch Control to Calcit 0.42.1 and refine joystick origin types) matches the main changes. The summary shows the Calcit version bump in …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "升级 Touch Control 到 Calcit 0.42.1 并细化摇杆原点类型" (Upgrade Touch Control to Calcit 0.42.1 and refine joystick origin types) matches the main changes. The summary shows the Calcit version bump in deps.cirru, package.json, and README, plus the change of *left-origin and *right-origin from Ref (List Number) to Ref (Tuple Number Number). The objectives also confirm both parts. The title is concise, specific, and written in the repository's language, and it names both the main upgrade and the origin type refinement.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 7162294a-2230-46cb-8c92-894ac23f2df4
Commits
Reviewing files that changed from the base of the PR and between 7f0d5c8 and 6ad9fc7.
Files ignored due to path filters: 1
yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 4
README.md
calcit.cirru
deps.cirru
package.json
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
用户影响
从源码构建请配对 Calcit 和 @calcit/procs 0.42.1。摇杆位移和回调格式保持原样。直接写入左右摇杆内部原点 Ref 的代码需要提供两个数字组成的坐标对。
改动和验证
Summary by CodeRabbit