I can't find any mechanism that is handling timeouts for any requests in client.js. It looks to me like if either (1) the agent never responds or (2) there's a socket level error, that exception gets swallowed and cb will never happen.
Client should have a timeout (or a per-request timeout option) after which the callback gets called with an error. Of course the current format passes the response as the first and only arg to callback, so maybe to maintain some semblance of backwards compat (it would still break existing users when an error occurs) we would call cb(null, err).
I can't find any mechanism that is handling timeouts for any requests in client.js. It looks to me like if either (1) the agent never responds or (2) there's a socket level error, that exception gets swallowed and cb will never happen.
Client should have a timeout (or a per-request timeout option) after which the callback gets called with an error. Of course the current format passes the response as the first and only arg to callback, so maybe to maintain some semblance of backwards compat (it would still break existing users when an error occurs) we would call
cb(null, err).