Repository navigation
Add security rules for fetched content and money-moving actions - #19
Open
armandocodecr wants to merge 1 commit into
Open
armandocodecr wants to merge 1 commit into
armandocodecr wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two medium warnings from the Snyk audit on skills.sh (2026-09-28).
Changes
constitution.md, Article V (Agent Conduct) — two new[SECURITY]rules:contractId, amounts and recipients, and waits for confirmation of that specific transaction. No signing or submitting without it, and no batching several such transactions under one approval. The rule also states that the REST API, SDK hooks and thetrustlessworkMCP server never sign: they build unsigned XDR and submit XDR that is already signed. I checked the MCP source; it has no signing code.SKILL.md— pointers to both rules in Common Transaction Flow and in MCP Integration.Expected effect
W011 flags the lack of an untrusted-content rule, so it should drop. W009 detects a capability class, and moving money is what this skill is for, so it will likely remain a warning. The skill now documents its safeguards alongside its capabilities. Snyk does not publish its scoring, so the next audit will confirm the effect.
scripts/check-consistency.shpasses.