Skip to content

The library is not thread safe when sending metric #10

Description

@shenmuxiaosen

We found out an exception like below:

System.InvalidOperationException: This BackgroundWorker is currently busy and cannot run multiple tasks concurrently.
at System.ComponentModel.BackgroundWorker.RunWorkerAsync(Object argument)
at StatsN.BaseCommunicationProvider.SendMetric(String metric)
at StatsN.Statsd.LogMetricAsync(String metricName, String value, String metricType, String postfix)

Looks like in BaseCommunicationProvider.SendMetric,

if (!worker.IsBusy) worker.RunWorkerAsync();

It does check if the worker is busy, but looks like this may not be thread safe.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions