CI: Silence warning by changing MSVC setup repo - #624
Closed
shinra-electric wants to merge 2 commits into
Closed
Conversation
Added architecture specification for MSVC setup.
Member
|
Thanks for the notice and the PR. But since the task this action performs is a fairly simple one, I believe it's better and safer to just set up this development shell manually like libass and mpv do. With this, Aegisub also no longer uses any non-official actions. So, I'll close this in favor of #628 . |
generic-pers0n
pushed a commit
to tenacityteam/tenacity
that referenced
this pull request
Jul 20, 2026
The ilammy/msvc-dev-cmd action is using outdated version of Node and generating tons of warnings on our cmake CI builds. A PR has been in that repo for months without response, and a newer fork exists with active developers which should be a drop-in replacement. This commit swaps that orphaned action out with the TheMrMilchmann/setup-msvc-dev action forked from the old no longer maintained action. The fork has consistent updates, including to Node 24, which silences the Node 20 errors we are experiencing. Reference-to: TypesettingTools/Aegisub#624 Signed-off-by: Emily Mabrey <emilymabrey93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows on from #623 aimed at silencing GitHub actions warnings, but I made this PR separate because it has some security implications.
This changes the
ilammy/msvc-dev-cmdaction to theTheMrMilchmann/setup-msvc-devfork.The original
ilammyaction has not been updated in several years, and is usingNode.js 20which will be disabled soon. A PR has been opened that updates it, but the original developer is not responsive.The
TheMrMilchmannfork is actively maintained and should be a drop-in replacement.The reason I separated this PR out is that changing the repo used is a security issue, and the new repo should be reviewed by anyone concerned.