Repository navigation
Conversation
Validated against dcm4chee, which is the only open MPPS implementation i know about
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+20
to
+24
| #[async_trait] | ||
| pub trait MppsService: Send + Sync { | ||
| /// Create Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.4.html> | ||
| async fn create(&self, request: MppsCreateRequest) -> Result<(), MppsError>; |
Comment on lines
+20
to
+28
| #[async_trait] | ||
| pub trait MppsService: Send + Sync { | ||
| /// Create Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.4.html> | ||
| async fn create(&self, request: MppsCreateRequest) -> Result<(), MppsError>; | ||
|
|
||
| /// Update Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.5.html> | ||
| async fn update(&self, request: MppsUpdateRequest) -> Result<(), MppsError>; |
Comment on lines
+20
to
+32
| #[async_trait] | ||
| pub trait MppsService: Send + Sync { | ||
| /// Create Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.4.html> | ||
| async fn create(&self, request: MppsCreateRequest) -> Result<(), MppsError>; | ||
|
|
||
| /// Update Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.5.html> | ||
| async fn update(&self, request: MppsUpdateRequest) -> Result<(), MppsError>; | ||
|
|
||
| /// Retrieve Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.6.html> | ||
| async fn retrieve(&self, request: MppsRetrieveRequest) -> Result<InMemDicomObject, MppsError>; |
Comment on lines
+20
to
+24
| #[async_trait] | ||
| pub trait MppsService: Send + Sync { | ||
| /// Create Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.4.html> | ||
| async fn create(&self, request: MppsCreateRequest) -> Result<(), MppsError>; |
Comment on lines
+20
to
+28
| #[async_trait] | ||
| pub trait MppsService: Send + Sync { | ||
| /// Create Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.4.html> | ||
| async fn create(&self, request: MppsCreateRequest) -> Result<(), MppsError>; | ||
|
|
||
| /// Update Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.5.html> | ||
| async fn update(&self, request: MppsUpdateRequest) -> Result<(), MppsError>; |
Comment on lines
+20
to
+32
| #[async_trait] | ||
| pub trait MppsService: Send + Sync { | ||
| /// Create Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.4.html> | ||
| async fn create(&self, request: MppsCreateRequest) -> Result<(), MppsError>; | ||
|
|
||
| /// Update Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.5.html> | ||
| async fn update(&self, request: MppsUpdateRequest) -> Result<(), MppsError>; | ||
|
|
||
| /// Retrieve Transaction. | ||
| /// <https://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_15.6.html> | ||
| async fn retrieve(&self, request: MppsRetrieveRequest) -> Result<InMemDicomObject, MppsError>; |
nickamzol
self-requested a review
October 27, 2026 07:51
nickamzol
added
service:mpps
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the MPPS part of #26 . We already have MWL-RS.
Uses parts of #63
Validated against dcm4chee, which is the only open MPPS implementation i know about