Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,19 @@ jobs:
include:
- dockerfile: Dockerfile
suffix: ""
features: mimalloc
- dockerfile: Dockerfile-s3
suffix: "-s3"
features: s3,mimalloc
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install cargo-about
uses: taiki-e/install-action@5488ac5a951645ce95062214902ac4b6bc1a1037 # v2.87.32
with:
tool: cargo-about@0.9.3
- name: Generate third-party licenses
run: cargo about generate --features ${{ matrix.features }} --locked --fail about.hbs -o licenses.html
- name: Log in to the Container registry
uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
with:
Expand Down
28 changes: 25 additions & 3 deletions .github/workflows/rust-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,25 @@ name: rust-checks
on:
pull_request:
workflow_dispatch:
permissions:
contents: read
jobs:
check-rust-build:
runs-on: ubuntu-latest
permissions:
contents: read
# required by upload-sarif
actions: read
security-events: write
services:
seaweedfs:
image: chrislusf/seaweedfs:4.51
ports:
- 8333:8333
options: >-
--health-cmd "curl -fsS -o /dev/null http://127.0.0.1:8333/healthz || exit 1"
--health-interval 2s
--health-retries 30
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
Expand All @@ -21,11 +37,11 @@ jobs:
cargo fmt --version
cargo clippy --version

- name: cargo check
run: cargo check
- name: cargo check (default features)
run: cargo check --all-targets

- name: cargo test
run: cargo test
run: cargo test --all-features

- name: cargo fmt
run: cargo fmt --all -- --check
Expand All @@ -43,3 +59,9 @@ jobs:
uses: github/codeql-action/upload-sarif@v4
with:
sarif_file: results.sarif

cargo-deny:
Comment thread
nickamzol marked this conversation as resolved.
Resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: EmbarkStudios/cargo-deny-action@v2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EmbarkStudios/cargo-deny-action@v2 is a movable tag; pin a full commit SHA, as the workflow already does for the cargo-about installer.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's good practice to use commit SHA's in github action workflow files

3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ target/

# Avoid adding config files that overwrite the default config
config.toml

# Third-party licenses, generated by cargo-about for the Docker images
licenses.html
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

## [0.3.4] - 2026-10-27

### Added

- Docker images now include the third-party licenses in `/usr/share/doc/dicom-rst/`, generated by [cargo-about](https://github.com/EmbarkStudios/cargo-about).

### Changed

### Fixed

- S3 retrieves no longer wait for the full object listing before streaming the first instance (#77).
- S3 instance retrieves now list objects by the prefix `{study}/{series}/{instance}.dcm` instead of `{study}/{series}/{instance}`.
- WADO-RS multipart responses now end with a CRLF after the close delimiter, so clients such as dicom-web no longer drop the last instance.

## [0.3.3] - 2026-09-28

### Fixed
Expand Down Expand Up @@ -143,3 +157,4 @@ It includes basic support for QIDO-RS, WADO-RS and STOW-RS for the DIMSE backend
[0.3.1]: https://github.com/UMEssen/DICOM-RST/releases/tag/v0.3.1
[0.3.2]: https://github.com/UMEssen/DICOM-RST/releases/tag/v0.3.2
[0.3.3]: https://github.com/UMEssen/DICOM-RST/releases/tag/v0.3.3
[0.3.4]: https://github.com/UMEssen/DICOM-RST/releases/tag/v0.3.4
Loading
Loading