Repository navigation
ci: fix yanked secp256k1 and 1.99 clippy lints - #58
Open
orbitalturtle wants to merge 4 commits into
Open
orbitalturtle wants to merge 4 commits into
orbitalturtle wants to merge 4 commits into
Conversation
rgb-lib 0.3.0-beta.7 requires secp256k1 ^0.32.0-beta.2, which has been yanked from crates.io. This repo doesn't commit Cargo.lock, so every CI run resolves from scratch and fails with 'version 0.32.0-beta.2 is yanked'. Patch the crate to the commit of its secp256k1-0.32.0-beta.2 tag; git sources aren't subject to yanking, and other secp256k1 versions in the graph still come from crates.io. Co-Authored-By: Claude
Since the Rust toolchain specified in .github/workflows/build.yml is floating and points to the latest "stable" Rust version, the lint now lints on Rust 1.99.0, which means new lint errors that we need to fix. Replace deprecated max_value() and core::uN::MAX with MAX, use vec![] and unwrap_or where clippy asks, add a missing semicolon, and allow the deprecated fetch_update since its replacement is far newer than our MSRV. Co-Authored-By: Claude
orbitalturtle
force-pushed
the
ci/fix-yanked-secp-and-lints-dev
branch
from
October 19, 2026 18:31
5be598c to
6fa36fa
Compare
orbitalturtle
changed the title
rgb-lib patches rgb-consensus/ops/invoicing/schemas to its BFA mirrors, but cargo patches don't propagate to dependents, so we built against the crates.io versions and rgb-lib failed to compile. Co-Authored-By: Claude
The BFA mirrors are private, which the default GITHUB_TOKEN can't read. Use the existing RGB_LIB_RUST_LIGHTNING_PAT for cargo's fetches. Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to make the CI green. Rebases RGB-Tools#41 onto this fork's
dev.This solves a couple of the issues, but there's another one that looks to be fixed partly in #57