Repository navigation
Adapt RGB wallet helpers to pinned rgb-lib-bfa graph - #59
Merged
Merged
Conversation
This was referenced Oct 20, 2026
Draft
gofman8
marked this pull request as ready for review
October 27, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RLN's focused migration needs LDK's RGB helpers to open the new
rgb-lib-bfawallet and retain its explicit indexer and EVM configuration. This adapts that boundary and pins the same library inlightningandlightning-invoice.191c8b8ab293f3bb1936fc01c1c10a6ffff91882abd41d3afff6d8fb11461e26e843301650e22df3The helpers use the new
WalletDataandOnlineOptions, select Electrum or Esplora from the configured URL, and retain the per-chain EVM endpoint map. BFA remains an explicit opt-in. External/watch-only signing stays in place; the new library uses fresh addresses. RLN #212 rejects unsupported address reuse at startup. This PR does not adopt the broader draft #57 or modify RLN #211.CI source authentication fails closed when the existing read credential is missing and scopes its URL rewrite to the exact private RGB repository. The build workflow retains the Electrum workspace checks and adds Esplora plus public RGB configuration tests.
Validation
lightning/electrumandlightning/esploraagainst the pinned RGB source.rgb_configintegration suite passed 4 tests per indexer feature, covering schema opt-in, URL selection, EVM endpoints, consistency policy and absence of invented credentials.The inherited full LDK
--libtest harness did not compile in the recorded attempt; its base already contains commented-out shared test helpers and incompatible legacy fixtures. The new public tests do not replace or establish a pass for that harness. Full funded LDK/RLN channel lifecycles, generated native artifacts and platform acceptance remain unqualified on this graph. No current-head hosted LDK result is recorded here.Integration order
Merge RGB #4 first, then this PR into
dev, preserving the reviewed commits. RLN #212 retains its canonical ancestry check: the exact pinned LDK commit must be reachable fromrust-lightning/devbefore that gate can pass. A squash or rebase requires downstream repinning and fresh qualification. No merge, publication, hosted bridge operation or repository administration change is included.