Skip to content

Adapt RGB wallet helpers to pinned rgb-lib-bfa graph - #59

Merged
gofman8 merged 6 commits into
devfrom
codex/rgb-lib-bfa-migration
Oct 27, 2026
Merged

gofman8 merged 6 commits into
devfrom
codex/rgb-lib-bfa-migration

Conversation

@Jainakin

@Jainakin Jainakin commented Oct 20, 2026 •

Copy link
Copy Markdown

RLN's focused migration needs LDK's RGB helpers to open the new rgb-lib-bfa wallet and retain its explicit indexer and EVM configuration. This adapts that boundary and pins the same library in lightning and lightning-invoice.

Component Reviewed source
This LDK candidate 191c8b8ab293f3bb1936fc01c1c10a6ffff91882
rgb-lib-bfa, RGB #4 abd41d3afff6d8fb11461e26e843301650e22df3

The helpers use the new WalletData and OnlineOptions, select Electrum or Esplora from the configured URL, and retain the per-chain EVM endpoint map. BFA remains an explicit opt-in. External/watch-only signing stays in place; the new library uses fresh addresses. RLN #212 rejects unsupported address reuse at startup. This PR does not adopt the broader draft #57 or modify RLN #211.

CI source authentication fails closed when the existing read credential is missing and scopes its URL rewrite to the exact private RGB repository. The build workflow retains the Electrum workspace checks and adds Esplora plus public RGB configuration tests.

Validation

  • Local Rust 1.94.0 workspace checks passed with lightning/electrum and lightning/esplora against the pinned RGB source.
  • The public rgb_config integration suite passed 4 tests per indexer feature, covering schema opt-in, URL selection, EVM endpoints, consistency policy and absence of invented credentials.
  • Credential-plumbing negative tests, workflow validation, whitespace checks and the existing workflow's Rust 1.63.0 formatting gate passed.
  • RGB 637 Rgb on Dev #4's exact source has seven passing CI jobs, including real funded fixed-locktime builders and protected sweeps. Those library tests are separate from LDK channel qualification.

The inherited full LDK --lib test harness did not compile in the recorded attempt; its base already contains commented-out shared test helpers and incompatible legacy fixtures. The new public tests do not replace or establish a pass for that harness. Full funded LDK/RLN channel lifecycles, generated native artifacts and platform acceptance remain unqualified on this graph. No current-head hosted LDK result is recorded here.

Integration order

Merge RGB #4 first, then this PR into dev, preserving the reviewed commits. RLN #212 retains its canonical ancestry check: the exact pinned LDK commit must be reachable from rust-lightning/dev before that gate can pass. A squash or rebase requires downstream repinning and fresh qualification. No merge, publication, hosted bridge operation or repository administration change is included.

@gofman8
gofman8 marked this pull request as ready for review October 27, 2026 12:23
@gofman8
gofman8 merged commit 17f2fb5 into dev Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants