Skip to content

Save and restore named filter sets from a pin beside the lock - #234

Open
dgruss wants to merge 2 commits into
feature/filter-suggestionsfrom
feature/filter-pin
Open

dgruss wants to merge 2 commits into
feature/filter-suggestionsfrom
feature/filter-pin

Conversation

@dgruss

@dgruss dgruss commented Oct 28, 2026 •

Copy link
Copy Markdown

Adds a pin beside the search dialog's lock. It opens Save current filters and the named sets available to restore. Saving asks for a name; replacing an existing set requires confirmation. Saved sets use the exact category/query rows and are reevaluated against the current library, playlist and lockdown context. Longer saved-set lists are paged.

Storage follows the configured playlists folder as filter-presets.json. An existing file in the game user directory is moved there when the destination is absent. The pin button can be positioned/styled by SongJumptoButtonPin; it otherwise follows the lock button. In-game help explains the control. The name prompt reuses the existing popup with a Name label and no password field.

Stacked on #232. Replaces the separate preset-menu approach from closed #226.

Validation: Windows build, English fallback and whitespace checks pass. The initial isolated-game build saved a Unicode set name and restored its exact filters through the actual popup callback. The subsequent playlists-storage change compiles, but its migration and final labeled dialogs still need runtime verification. Native persistence regression source is included.

Refs #205.

@dgruss

dgruss commented Oct 28, 2026

Copy link
Copy Markdown
Author

The pin is beside the lock in the search dialog. It opens the saved filter sets and the action to save the current set with a name.

pin-in-search

@dgruss
dgruss marked this pull request as ready for review October 28, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant