Repository navigation
Record upstream completion-refactor ancestry - #245
Merged
Merged
Conversation
Refactor SungToEnd Logic
The change is incorporated by PR 243. Preserve weighted and excluded-note scoring, assigned voices, medley updates, and the separately tested audio-boundary correction. This merge changes history ancestry only, not the file tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record UltraStar-Deluxe#1467 and its upstream merge commit as incorporated, following the adapted implementation merged in #243.
The ancestry merge has the exact same file tree as #244. It preserves USCE's configured scoring weights, excluded notes, assigned voices and medley handling. Once #244 is merged, this PR has no file changes. Merge with a merge commit so the original upstream commits become ancestors of main and GitHub no longer reports those two commits as missing.
No independent human review is available during the solo-maintainer phase.