Repository navigation
Fix "headers ended early" downloads and haru's look on Windows - #6
Merged
Merged
Conversation
Moves the tapline submodule from 1c5153d to 1b133b6, which picks CDN hosts the way SteamKit does, retries manifest fetches on other hosts and stops reusing connections the CDN has already closed. It also brings in tapline #2 (the bug pass), which haru had not picked up yet. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JPbjRcr2kuhRi1wBhGk1ax
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (15)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tors
On Windows in light mode most of haru was unreadable: buttons, checkboxes
and fields came out light grey with haru's light text on them, and headings
went dark on haru's dark panels. egui keeps a style per theme and follows the
system's, so the first frame swapped in its stock light style underneath
haru's own panel colours. Linux rarely reports a theme, so it never showed.
haru now asks for the dark theme outright, gives both slots its style, and
asks for a dark title bar.
- haru.exe carries its icon as a resource (embed-resource), so Explorer and
the taskbar show it rather than the blank default.
- Screens kirie calls DISPLAY6 are shown by the monitor's own name
("DELL U2720Q"), or "Display 6" when it has none. Commands still use
kirie's name.
- The control socket field's placeholder is the real default path, not a
Linux one.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DDe3iPz1un8WXmFsmkHec4
The previous pin, 1b133b6, was tapline #3's branch head, which was cut from 1c5153d and so did not contain tapline #2 (auth token ACL, ffi event loss, SteamAppId message). 8c439f1 is tapline main after #3 merged and carries both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BjWixYpwMjeckvBT82WjHZ
beingsuz
marked this pull request as ready for review
September 26, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by beingsuz · project thread
Wallpaper downloads
Before: downloading a wallpaper in haru v0.7.0 on Windows failed with "fetch failed: malformed response: headers ended early".
After: the download tries other CDN hosts and avoids the servers that hang up.
How: bumps the tapline submodule from 1c5153d to 8c439f1, tapline main after UnhingedSoftware/tapline#3 merged. That brings in tapline #3 (the CDN fix) and tapline #2 (the bug pass), which haru had not picked up. An earlier commit here pinned 1b133b6, tapline #3's branch head, which had been cut before tapline #2 and so did not contain it.
Windows visuals (thread)
Before: on Windows in light mode, buttons, checkboxes and fields were light grey with light text on them (the Preview page's button looked blank), headings and the "haru" title were dark on dark, haru.exe had no icon in Explorer, screens were called
DISPLAY6, and the control socket field suggested/run/user/1000/lwe.sock.After: haru is dark everywhere with a dark title bar, the exe carries its icon, screens show the monitor's own name (or "Display 6" when it has none), and the socket placeholder is the real default path.
How: egui keeps one style per theme and follows the system's. On Windows in light mode it switched to its stock light style on the first frame, underneath haru's own panel colours.
theme::applynow sets the dark theme, gives both theme slots haru's style, and sendsSetTheme(Dark)for the title bar. The icon ispackaging/haru.icoembedded byembed-resourcefromcrates/haru/build.rs; the build fails rather than shipping an exe without it. Monitor names come fromdisplay-info(Windows-only dependency, so no newunsafein haru), looked up only when the set of screens changes; commands to kirie still use kirie's name.Verified
cargo clippy --workspace --all-targets -D warningsclean on Linux and cross-compiled forx86_64-pc-windows-gnu;cargo test --workspacepasses on Linux (175 tests, re-run against tapline 8c439f1), including new tests for the monitor labels.wrestool).Not verified: nothing run on real Windows, the MSVC release build's resource compiler step, friendly monitor names on real monitors (Wine has none), and no live download.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DDe3iPz1un8WXmFsmkHec4