fix(rest/python): scope idempotency hashes to checkout operations - #166
Open
WenshuangQuan-TT wants to merge 1 commit into
Open
Conversation
Include the operation and target checkout in each request fingerprint so an idempotency key cannot replay a response for a different resource. Add regression coverage for update, complete, and cancel while preserving same-request retries.
damaz91
approved these changes
Aug 5, 2026
ptiper
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Idempotency records are keyed globally, but the previous request hash only covered the request body. The checkout ID lives in the URL for update, complete, and cancel requests, and cancel requests all have the same empty body. Reusing a key for a different checkout could therefore return the first checkout's cached response with HTTP 200 while leaving the requested checkout unchanged.
The request fingerprint now includes the operation, resource ID, and request data. Exact retries still return the cached response, while reusing the key for a different operation or checkout returns
409 IDEMPOTENCY_CONFLICT.Testing
.venv/bin/python -m pytest -v(133 passed,6 subtests passed)git diff --check origin/main..HEAD