Skip to content

fix(analytics): validate range parameter and return 400 for unsupport… #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jikrana1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(analytics): validate range parameter and return 400 for unsupport… #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions backend/controllers/analyticsController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,16 @@ const getSummary = async (req, res) => {
// GET /analytics/trends?range=daily|weekly|monthly
const getTrends = async (req, res) => {
try {
const range = ANALYTICS_RANGES.includes(req.query.range)
? req.query.range
: "daily";
const { range } = req.query;

if (range !== undefined && !ANALYTICS_RANGES.includes(range)) {
return res.status(400).json({
error: `Invalid range value. Supported values are: ${ANALYTICS_RANGES.join(', ')}.`
});
}

// If range is not provided, default to 'daily'
const selectedRange = range || "daily";

const userId = getUserObjectId(req);
const trends = await History.aggregate([
Expand All @@ -115,7 +122,7 @@ const getTrends = async (req, res) => {
{
$group: {
_id: {
date: { $dateToString: { format: DATE_FORMATS[range], date: "$createdAt" } },
date: { $dateToString: { format: DATE_FORMATS[selectedRange], date: "$createdAt" } },
label: "$prediction",
},
count: { $sum: 1 },
Expand Down
Loading