Repository navigation
Conversation
The pid file survives reboot. When its pid was reused by another process, kill -0 succeeded and the scheduler loop never started for that boot. Match the loop's own command line, which carries the pid file path. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 619fbf6)
Each batch item runs restore() in a subshell, which runs no EXIT trap, so verifier_restore never ran and the next item saved 0 as the old value. verifier_verify_adb_installs and package_verifier_enable stayed off. Turn the verifier off once in restore_batch and restore it there. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit cb1454e)
scheduler-tick and the auto-backup observer started one detached worker per package, all at once, and pruned right after starting them. A job for all apps therefore ran every backup in parallel, and pruning counted the backups still being written, so a failed run could leave one good backup fewer than keep. - Each due job now starts one backup-batch (or restore-batch) op for its targets; the auto-backup observer starts one backup-batch. - Scheduled and auto batches carry keep; backup_batch prunes an app to keep finished backups only after that app's backup succeeded. - prune_pkg counts and removes only backups with a manifest.json. - scheduler-tick no longer reports pruned refs (pruning happens later, in the worker, and is still audited). Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit c5a219e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scheduler and batch fixes: a stale scheduler pid from before a reboot is no longer trusted, each scheduled job runs as one batch op and prunes only after it succeeds, and the install verifier setting is put back after a batch restore.
One commit per fix, so any of them can be dropped on its own. Each line links the draft PR on my fork that has the full write-up and repro for that fix.
Checklist
lang/<code>.jsonandREADME.<code>.mdwere updated. (no UI label changes)git commit -s).sh -n,mksh -n,busybox sh -nandshellcheck -s sh(no new warnings), small mksh/busybox repro scripts per fix, and thetools/screenshotsPlaywright mocks (en and ar) for WebUI changes.Notes
Merge with or after the restore-safety PR is fine; they touch different functions.
The five grouped PRs (restore safety, scheduler, destinations, WebUI fixes, performance) merge cleanly together in any order; I checked that combining all of them gives the same tree as my test build.