Repository navigation
Conversation
Telegram stores one archive per app backup and telegram-pull restores only those. A folder or /data/adb backup to Telegram failed at upload time, after the local copy was written, and could not have been pulled back. Refuse it right after the destination is resolved with ERR_TG_KIND, and add the matching English message. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 98798e3)
The default local destination has no path, so Mirror mode wrote to and restored from "vdbackup" relative to the worker's cwd. Default it to .mirror in the user's backups dir, and refuse a local Mirror path that fails safe_local_dest, as a full backup's local copy already does. A failed APK sync now also fails the mirror instead of being ignored. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 3069978)
ConsentActivity is exported so root can start it, which means any app can start it too and pick the result path. Accept only a consent.* file directly in filesDir, which is what the WebUI passes. Fix the README example, which pointed at /data/adb (not writable by the app). Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 26971c9)
Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Destination fixes: folder and /data/adb backups are refused for a Telegram destination with a clear error (ERR_TG_KIND) instead of failing later, a local Mirror gets an absolute, allowed destination path, and the Google Drive companion writes its consent result only inside its own files dir.
One commit per fix, so any of them can be dropped on its own. Each line links the draft PR on my fork that has the full write-up and repro for that fix.
Checklist
lang/<code>.jsonandREADME.<code>.mdwere updated. (msg_err_tg_kindadded toen.js,en.jsonand every<code>.json; no README text changes)git commit -s).sh -n,mksh -n,busybox sh -nandshellcheck -s sh(no new warnings), small mksh/busybox repro scripts per fix, and thetools/screenshotsPlaywright mocks (en and ar) for WebUI changes.Notes
The companion change (Kotlin) was not compiled here.
The five grouped PRs (restore safety, scheduler, destinations, WebUI fixes, performance) merge cleanly together in any order; I checked that combining all of them gives the same tree as my test build.