Skip to content

webui: error reporting and small UI fixes - #22

Open
ash-iir wants to merge 7 commits into
VD171:mainfrom
ash-iir:up-webui-fixes
Open

ash-iir wants to merge 7 commits into
VD171:mainfrom
ash-iir:up-webui-fixes

Conversation

@ash-iir

@ash-iir ash-iir commented Nov 19, 2026

Copy link
Copy Markdown

What

WebUI fixes: delete failures and unsaved passphrases are reported instead of silently ignored, an authorized rclone remote is added only once, the adb tree indents on the reading side in RTL, the overview size uses toybox du, and VDLU config writes are serialized so two writes no longer race.

One commit per fix, so any of them can be dropped on its own. Each line links the draft PR on my fork that has the full write-up and repro for that fix.

  • helper: overview backups size with toybox du (details)
  • webui: show why a delete failed (details)
  • webui: indent the adb tree on the reading side (details)
  • webui: add an authorized rclone remote only once (details)
  • webui: report a passphrase that wasn't saved (details)
  • webroot: serialize VDLU config writes (details)

Checklist

  • The project banner header is present on every new/changed source file. (no new files)
  • Code and comments are in English; no em/en-dashes.
  • If a UI label changed, all lang/<code>.json and README.<code>.md were updated. (msg_err_dest_has_backups added to en.js, en.json and every <code>.json; no README text changes)
  • No real feature (SELinux/uid-gid/modes preservation, etc.) was weakened.
  • Commits are signed off (git commit -s).
  • Tested on a rooted device/emulator (note which). Not tested on a rooted device or emulator. Checked with sh -n, mksh -n, busybox sh -n and shellcheck -s sh (no new warnings), small mksh/busybox repro scripts per fix, and the tools/screenshots Playwright mocks (en and ar) for WebUI changes.

Notes

vdlu.js is vendored; the config-write race fix may also be wanted in its upstream source.

The five grouped PRs (restore safety, scheduler, destinations, WebUI fixes, performance) merge cleanly together in any order; I checked that combining all of them gives the same tree as my test build.

toybox du has no -B, so du -s -B1 printed nothing and backups_size was
always 0. Use du -sk and multiply, as the other size checks already do.

Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit 7da82e9)
remote-del, dest-del and schedule-delete ignored the helper result, so a
refused delete (e.g. ERR_DEST_HAS_BACKUPS) looked like nothing happened.
Show errMsg(r) like the other actions, and add msg_err_dest_has_backups.

Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit dd7a2e8)
The /data/adb browser indented nested rows with paddingLeft, which is the
trailing side in RTL languages. Use paddingInlineStart.

Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit ef20998)
Coming back from the consent page fires focus and visibilitychange, and
the interval may have a poll in flight too. Every poll that saw done
called addRemote. Only the first one, while _authActive is set, does.

Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit 3c43750)
pass-set-global and pass-set-app ignored the helper result, so a failed
save still showed "set" (or nothing at all) and the user believed future
backups were encrypted. Show errMsg(r) and only update the state on ok.

Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit 75d401e)
writeConfig builds the whole config file from cfgCache, which was only
updated after the write finished, so a second write started before the
first resolved dropped the first one's key on disk while the UI still
showed it on. Chain the writes so each starts from the result of the
previous one.

Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit c533c2e)
Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant