Repository navigation
Conversation
toybox du has no -B, so du -s -B1 printed nothing and backups_size was always 0. Use du -sk and multiply, as the other size checks already do. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 7da82e9)
remote-del, dest-del and schedule-delete ignored the helper result, so a refused delete (e.g. ERR_DEST_HAS_BACKUPS) looked like nothing happened. Show errMsg(r) like the other actions, and add msg_err_dest_has_backups. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit dd7a2e8)
The /data/adb browser indented nested rows with paddingLeft, which is the trailing side in RTL languages. Use paddingInlineStart. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit ef20998)
Coming back from the consent page fires focus and visibilitychange, and the interval may have a poll in flight too. Every poll that saw done called addRemote. Only the first one, while _authActive is set, does. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 3c43750)
pass-set-global and pass-set-app ignored the helper result, so a failed save still showed "set" (or nothing at all) and the user believed future backups were encrypted. Show errMsg(r) and only update the state on ok. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 75d401e)
writeConfig builds the whole config file from cfgCache, which was only updated after the write finished, so a second write started before the first resolved dropped the first one's key on disk while the UI still showed it on. Chain the writes so each starts from the result of the previous one. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit c533c2e)
Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WebUI fixes: delete failures and unsaved passphrases are reported instead of silently ignored, an authorized rclone remote is added only once, the adb tree indents on the reading side in RTL, the overview size uses toybox
du, and VDLU config writes are serialized so two writes no longer race.One commit per fix, so any of them can be dropped on its own. Each line links the draft PR on my fork that has the full write-up and repro for that fix.
Checklist
lang/<code>.jsonandREADME.<code>.mdwere updated. (msg_err_dest_has_backupsadded toen.js,en.jsonand every<code>.json; no README text changes)git commit -s).sh -n,mksh -n,busybox sh -nandshellcheck -s sh(no new warnings), small mksh/busybox repro scripts per fix, and thetools/screenshotsPlaywright mocks (en and ar) for WebUI changes.Notes
vdlu.jsis vendored; the config-write race fix may also be wanted in its upstream source.The five grouped PRs (restore safety, scheduler, destinations, WebUI fixes, performance) merge cleanly together in any order; I checked that combining all of them gives the same tree as my test build.