Repository navigation
Conversation
The backup list started one backup-icon helper call per row on every
render (search keystroke, select toggle), and any failed call cached
"no icon" for that backup for good.
- New backup-icons helper verb: {refs:[...]} -> {ok, icons:{ref: b64
or ""}}, one process per batch.
- Backup icons load through iconObserver like app icons, in batches of
ICON_BATCH, with one in-flight request per ref.
- Only an answered ref is cached; "" caches as no icon, a failed call
is retried on a later render.
Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
(cherry picked from commit d3fcf12)
A blur behind the sticky top bar and the fixed bottom tabs makes the compositor re-blur what scrolls under them on every frame, which is the main source of scroll stutter. Use the opaque page background instead (the bars were already 86-90% opaque, so the look barely changes) and a slightly darker scrim for modals. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 99a9b48)
loadApps rebuilt the Excluded apps and Per-app items pickers on every app list load, so the full list was rendered three times on boot (and on every refresh or user switch) while the Settings tab was hidden. loadSettings already rebuilds both pickers when the tab opens; skip the build while it is not shown. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 9f8134e)
The manager bridge runs one exec at a time, so call order is load order. Boot queued sanitize, dests-list, remote-list, pass-status, overview and list-ops ahead of list-apps, so the first screen waited behind calls only other tabs need. loadUsers/loadApps now return their promise; the other boot calls are queued once the app list request has settled. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit 09bbbd1)
A long press on a tab, button or tappable row started a text selection and the WebView callout menu, which is what makes the UI feel like a web page. Turn off user-select and the touch callout on controls and row labels, and set touch-action: manipulation on tappable elements. Text in notices, dialogs and the log stays selectable. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com> (cherry picked from commit c7d6687)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WebUI performance and feel. Measured with the
tools/screenshotsmocks in headless Chromium at 412x915 with 6x CPU throttle and each exec delayed 120 ms and serialized, like the manager bridge. 300 apps, 150 backups:backdrop-filteron the sticky bars)backup-iconshelper verb)One commit per fix, so any of them can be dropped on its own. Each line links the draft PR on my fork that has the full write-up and repro for that fix.
Checklist
lang/<code>.jsonandREADME.<code>.mdwere updated. (no UI label changes)git commit -s).sh -n,mksh -n,busybox sh -nandshellcheck -s sh(no new warnings), small mksh/busybox repro scripts per fix, and thetools/screenshotsPlaywright mocks (en and ar) for WebUI changes.Notes
Desktop headless Chromium is not an Android WebView, so expect different numbers on a phone. With real root exec latency the boot-order gain should be larger.
The five grouped PRs (restore safety, scheduler, destinations, WebUI fixes, performance) merge cleanly together in any order; I checked that combining all of them gives the same tree as my test build.