build: default to Release, gate cat-parts to Windows, translate CMake comments - #146
Closed
chiliec wants to merge 1 commit into
Closed
build: default to Release, gate cat-parts to Windows, translate CMake comments#146chiliec wants to merge 1 commit into
chiliec wants to merge 1 commit into
Conversation
… comments Three low-risk CMake cleanups; no source logic touched. - Default CMAKE_BUILD_TYPE to Release when unset on single-config generators. Previously a bare `cmake ..` (or an IDE not passing -DCMAKE_BUILD_TYPE) configured with empty optimization flags -> an unoptimized node. Guarded on GENERATOR_IS_MULTI_CONFIG so MSVC / Ninja Multi-Config are untouched (they pick the config at build time). build-linux.sh/build-mac.sh always pass a type, so their behavior is unchanged. - Build cat-parts only on MSVC/MinGW. The hardfork concatenator is invoked solely under if(MSVC OR MINGW) in libraries/chain/CMakeLists.txt; every other platform uses cat_parts.py. Linux/macOS builds were compiling and linking a tool they never run. The only $<TARGET_FILE:cat-parts> reference is inside the matching MSVC/MinGW guard, so non-Windows builds are unaffected. - Translate five leftover Romanian comments (root CMakeLists.txt x2, libraries/chain/CMakeLists.txt x3) to English.
Member
|
Folded into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three low-risk CMake cleanups from the repo review. No source logic touched.
A. Default
CMAKE_BUILD_TYPEto Release when unsetThere was no default build type anywhere in the tree. A bare
cmake ..— or an IDE that doesn't pass-DCMAKE_BUILD_TYPE— configured the project with empty optimization flags, producing an unoptimized node. Added a standard guard that defaults toRelease.GENERATOR_IS_MULTI_CONFIG, so multi-config generators (MSVC, Ninja Multi-Config) are left alone — they pick the config at build time and are meant to have an emptyCMAKE_BUILD_TYPE.build-linux.shandbuild-mac.shalways pass an explicit type, so their behavior is unchanged; this only affects hand/IDE configures that previously got no optimization.B. Build
cat-partsonly on MSVC/MinGWprograms/build_helpers/CMakeLists.txtcompiled and linked thecat-partshardfork concatenator on every platform, butlibraries/chain/CMakeLists.txtonly invokes it underif(MSVC OR MINGW)— Linux and macOS usecat_parts.pyinstead. So non-Windows builds were compiling+linking a tool they never run. Wrappedadd_executable(cat-parts …)in the sameif(MSVC OR MINGW)guard.Verified the only
$<TARGET_FILE:cat-parts>reference lives inside the matching MSVC/MinGW branch; theelse()path uses Python and never touches the target, so non-Windows builds are unaffected.C. Translate leftover Romanian CMake comments
Five comments left over from a prior edit were in Romanian. Translated to English to match the rest of the files:
CMakeLists.txt—# Păstrăm inițializarea…,# bcrypt trebuie sa fie…libraries/chain/CMakeLists.txt—# Target comun…,# Marchează fișierul…,# Variabila folosită…