fix: handle pathlib.Path in get_pdf_name to avoid UnboundLocalError#349
Open
ChiragB254 wants to merge 1 commit into
Open
fix: handle pathlib.Path in get_pdf_name to avoid UnboundLocalError#349ChiragB254 wants to merge 1 commit into
ChiragB254 wants to merge 1 commit into
Conversation
get_pdf_name() only handled str and BytesIO; passing a pathlib.Path left pdf_name unbound and raised UnboundLocalError on return. - Extend the str branch to accept Path via isinstance(pdf_path, (str, Path)) (os.path.basename handles Path natively, so no extra conversion needed) - Add a safe else fallback returning 'Untitled' for any unrecognised type - Add tests covering str, Path (absolute + relative), and unknown type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_pdf_name()inpageindex/index/utils.pyonly handledstrandBytesIOinputs. Passing apathlib.Path— which is idiomatic Python and already imported in the same file — leftpdf_nameunbound and raisedUnboundLocalErrorat thereturnstatement, crashingJsonLogger.__init__before any indexing begins.Root cause
Fix
os.path.basenamehandlespathlib.Pathnatively (Python 3.6+), so no extra conversion is needed.Tests added (
tests/test_get_pdf_name.py)test_get_pdf_name_strtest_get_pdf_name_pathlib_pathUnboundLocalErrortest_get_pdf_name_pathlib_relativePathalso workstest_get_pdf_name_unknown_type_returns_untitled