Skip to content

feat: preview module definitions in tag completions - #116

Open
ViTeXFTW wants to merge 2 commits into
devfrom
t3code/implement-feature-request
Open

feat: preview module definitions in tag completions#116
ViTeXFTW wants to merge 2 commits into
devfrom
t3code/implement-feature-request

Conversation

@ViTeXFTW

@ViTeXFTW ViTeXFTW commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • show the defining module header as Markdown documentation for RemoveModule/ReplaceModule tag completions
  • preserve module preview metadata across workspace indexing and inherited default tags
  • add analysis, conversion, and end-to-end coverage

Validation

  • cargo test
  • python crates/server/tests/e2e.py target/debug/zerosyntax-lsp.exe

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds Markdown module-definition previews to RemoveModule and ReplaceModule tag completions.

  • Preserves module preview metadata through workspace indexing and inherited default tags.
  • Converts preview text into LSP Markdown completion documentation.
  • Bumps the persistent cache producer ABI for the serialized index shape change.
  • Adds analysis, conversion, and end-to-end coverage.

Confidence Score: 5/5

The PR appears safe to merge with no outstanding findings.

The previous cache-compatibility finding was fixed by changing the producer ABI from v2 to v3, so stale payloads using the old serialized shape are no longer selected; the thread was also manually resolved.

Important Files Changed

Filename Overview
crates/analysis/src/completion.rs Adds optional completion documentation and populates it with defining module headers for effective module tags.
crates/analysis/src/index.rs Indexes module-header snippets and carries them through effective module tag lookup, including inherited defaults.
crates/server/src/cache.rs Bumps the cache producer ABI to prevent selection of payloads serialized with the previous ModuleTagDefinition shape.
crates/server/src/convert.rs Converts analysis completion documentation into LSP Markdown markup.
crates/server/tests/e2e.py Verifies that RemoveModule completions expose the defining module as Markdown documentation.

Reviews (2): Last reviewed commit: "fix: bump workspace cache producer ABI" | Re-trigger Greptile

Comment thread crates/analysis/src/index.rs
@ViTeXFTW

ViTeXFTW commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

@greptileai

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Want your agent to iterate on Greptile's feedback? Try greploops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant