feat: Improve bone name completions and validation - #117
Merged
Conversation
|
| Filename | Overview |
|---|---|
| crates/analysis/src/completion.rs | Resolves active structured value types and emits mode-aware, deduplicated model-member completions with correct prefix insertion. |
| crates/analysis/src/diagnostics.rs | Validates every applicable raw value token using split-prefix-aware type resolution and field-specific member modes. |
| crates/analysis/src/model.rs | Centralizes qualified-name normalization, numbered-family generation, matching, and contextual RandomBone mode resolution. |
| crates/schema/src/lib.rs | Adds backward-compatible schema metadata for audited model-member lookup semantics and shared token-position helpers. |
| crates/schema/schema.json | Applies audited lookup modes to affected bone fields and types TransitionDamageFX bone values as model members. |
| crates/analysis/tests/bone_names.rs | Covers alias deduplication and prefix-preserving completion across attached and split Bone syntax. |
| crates/analysis/tests/spec/BoneNames.spec.toml | Specifies exact, indexed, and RandomBone-dependent completion and diagnostic behavior. |
| docs/bone-names.md | Documents field modes, numbered-family assumptions, split syntax, alias behavior, and audited engine references. |
Reviews (1): Last reviewed commit: "Improve bone name completions and valida..." | Re-trigger Greptile
ViTeXFTW
force-pushed
the
t3code/fix-bone-name-completions
branch
from
September 5, 2026 09:26
3b8b17b to
9267d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bone-valued fields had inconsistent completion and validation behavior. Numbered bones such as
Fire01were collapsed toFire, and model-qualified aliases could appear as duplicate suggestions.What changed
RandomBonefields.Bone: valuesyntax.Validation
cargo test --workspacecargo test -p zerosyntax-schemacargo test -p zerosyntax-analysis --test speccargo test -p zerosyntax-analysis --test bone_namescargo clippy --locked --all-targets --all-features -- -D warningscargo fmt --all --checkCloses #114